sakura keeps blinking on BEL even after window has had focus

[Kevin Brubeck Unhammer]

To reproduce, open sakura, enter

   $ sleep 5; printf '\a'

and immediately minimise the window, then wait for it to start blinking in the task bar / panel (I use Xubuntu and see it on my xfce panel).

Then raise the window again, and minimise it again. It'll keep blinking in the task bar.

Expected behaviour: after raising the window, it shouldn't blink again when minimised until another BEL is received.

[Kevin Brubeck Unhammer (unhammer)]

(This is Version: 3.6.0-3 on Xubuntu 18.10)

[David Gómez (dabisu)]

Hi. Sakura doesn't do any blinking. It just sets the urgency hint, and is the window manager (xfce in this case) which decides what to do when a window has the urgency hint.

[Kevin Brubeck Unhammer (unhammer)]

But it works as expected in stterm (/usr/bin/st) with xfce – there I can do `sleep 5;printf '\a'`, minimize, and see it blink, then when I raise and minimize again it stops blinking.

Also, weirdly, if I use `wmctrl -r sakura -b add,demands_attention` (from some other terminal) to make sakura start blinking, it works as expected (raising and minimizing sakura makes it stop blinking). It's only the `\a` / BEL printing that makes sakura keep blinking.

Why does `\a` work fine with st, and why does `demands_attention` work fine in sakura, when `\a` does not in sakura?

[David Gómez (dabisu)]

Let me check, I don't have a xfce installed right now.

[Kevin Brubeck Unhammer (unhammer)]

Hm, by running `xprop -spy` on stterm, it seems st unsets the urgency bit when raised. https://tronche.com/gui/x/icccm/sec-4.html#WM_HINTS says "Clients must provide some means by which the user can cause the UrgencyHint flag to be set to zero or the window to be withdrawn." but from how I read it it doesn't seem like it's the WM's job to turn turn it off.

It seems demands_attention is a different thing, which "should be unset by the Window Manager" according to https://specifications.freedesktop.org/wm-spec/wm-spec-1.3.html (and xfce does the right thing there with sakura).

[David Gómez (dabisu)]

Finally checked it against xfce and got it fixed. Thanks for the reports! Please let me know if the fix works for you.

[Kevin Brubeck Unhammer (unhammer)]

That does fix it, thanks =D