Hexadecimal WINDOWID breaks w3m-img
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Sakura |
Fix Released
|
Low
|
David Gómez |
Bug Description
The w3m-img browser has the ability to show images in a terminal. This is used for example by the ranger[1] file manager to preview image files (see [2] for an example). This works fine in xterm, but does not work with sakura. It turns out that xterm saves the WINDOWID variable as a decimal numer:
$ echo $WINDOWID
67108879
while sakura as a hexadecimal number:
$ echo $WINDOWID
0x3e00003
Converting WINDOWID from hexadecimal to decimal, for example like this:
$ export WINDOWID=
$ echo $WINDOWID
65011715
fixes the issue: w3m-img works fine in sakura too. Permanently fixing this should be as easy as changing sakura.c:2800 from
gchar *winidstr = g_strdup_printf ("0x%x", winid);
to
gchar *winidstr = g_strdup_printf ("%d", winid);
Please consider applying this simple patch.
The credit for the workaround goes to [3].
[1] http://
[2] http://
[3] http://
Related branches
- No reviews requested
Changed in sakura: | |
status: | Fix Committed → Fix Released |
Thanks, fix added.