setting colors breaks cursor color

[Steven Noonan]

I noticed when playing NetHack that if I saved the color settings, it would break the highlighting of my character in-game (instead of a color-inverted @ sign, it shows a white block). See attached screenshots for example.

I found that this change fixes it:

diff --git a/src/sakura.c b/src/sakura.c
index 6e81968..bbcacb5 100644
--- a/src/sakura.c
+++ b/src/sakura.c
@@ -1113,11 +1113,11 @@ sakura_set_colors ()

        for (i = (n_pages - 1); i >= 0; i--) {
                term = sakura_get_page_term(sakura, i);
+ vte_terminal_set_color_cursor(VTE_TERMINAL(term->vte), &sakura.curscolors[term->colorset]);
                vte_terminal_set_colors(VTE_TERMINAL(term->vte),
                                        &sakura.forecolors[term->colorset],
                                        &sakura.backcolors[term->colorset],
                                        sakura.palette, PALETTE_SIZE);
- vte_terminal_set_color_cursor(VTE_TERMINAL(term->vte), &sakura.curscolors[term->colorset]);
        }

 }

[Steven Noonan (steven-valvesoftware)]

Bah, that patch is bogus. If I apply that patch and then try to set a custom cursor color, it doesn't apply. I guess the previous ordering is correct (and should be fixed in the other place that vte_terminal_set_colors is called after vte_terminal_set_color_cursor). But there's still the matter of getting the cursor inversion to behave. I know that xfce4-terminal seems to behave at least...

[David Gómez (dabisu)]

Hello Steve, could you please check if the bug is it now fixed with latest revision code?