sakura cannot use custom icon using full path
Bug #1520779 reported by
Andreas Rönnquist
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Sakura |
Fix Released
|
Low
|
David Gómez | ||
Bug Description
Using the --icon setting, I expected the option to take a full path, but something like
sakura --icon /usr/share/
didn't work.
Debugging some I discover that it builds a path for the custom icon using
(DATADIR "/pixmaps/%s", option_icon)
which makes it unnecessarily hard to customize the icon if I want to provide a full path to an image file. Otherwise you cannot simply use a file from somewhere in /usr/ when you have built from source which sets DATADIR to /usr/local/ .
My suggested patch attached (I am not very good at bzr so I cannot provide any bzr-specific patch, but I suppose you can do something with this).
Related branches
lp:~dabisu/sakura/sakura
- No reviews requested
Revision history for this message
| Andreas Rönnquist (gusnan) wrote | #1 |
Revision history for this message
| David Gómez (dabisu) wrote | #2 |
| Changed in sakura: | |
| assignee: | nobody → David Gómez (dabisu) |
| importance: | Undecided → Low |
| status: | New → Fix Committed |
| Changed in sakura: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Agreed. It's better to use the full path because is a customization option. Thanks for the patch Andreas.