GTK3 stock items deprecated

[Xaocon]

https://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-STOCK-CLOSE:CAPS

Shows one that is depreciated in 3.10 but there are several more. Noticed when I tried to build:

http://ix.io/8Ww

with GTK 3.10.2.

[DAP (darkness)]

Sorry for my importunity. How can i get a patch to apply it to 3.1.1 tarball?

[David Gómez (dabisu)]

You can generate a patch with 'bzr diff'. But i'll release a 3.1.2 soon, maybe even today.

[DAP (darkness)]

I've already failed to do it via bzr, so I'd better wait for release :)

[DAP (darkness)]

Another issue :(
[ 68s] + cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=RelWithDebInfo '-DCMAKE_C_FLAGS=-DNDEBUG -fomit-frame-pointer -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -g' '-DCMAKE_CXX_FLAGS=-DNDEBUG -fomit-frame-pointer -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -g' ..
[ 69s] -- The C compiler identification is GNU 4.8.1
[ 69s] -- The CXX compiler identification is GNU 4.8.1
[ 69s] -- Check for working C compiler: /usr/bin/cc
[ 69s] -- Check for working C compiler: /usr/bin/cc -- works
[ 71s] -- Detecting C compiler ABI info
[ 71s] -- Detecting C compiler ABI info - done
[ 71s] -- Check for working CXX compiler: /usr/bin/c++
[ 71s] -- Check for working CXX compiler: /usr/bin/c++ -- works
[ 71s] -- Detecting CXX compiler ABI info
[ 71s] -- Detecting CXX compiler ABI info - done
[ 71s] -- Found PkgConfig: /usr/bin/pkg-config (found version "0.28")
[ 71s] -- checking for module 'glib-2.0>=2.20'
[ 71s] -- found glib-2.0, version 2.38.1
[ 71s] -- checking for module 'gtk+-3.0'
[ 71s] -- found gtk+-3.0, version 3.10.2
[ 71s] -- checking for module 'vte-2.90>=0.28'
[ 71s] -- found vte-2.90, version 0.34.9
[ 71s] pod2man executable is/usr/bin/pod2man
[ 71s] -- Configuring done
[ 71s] -- Generating done
[ 71s] -- Build files have been written to: /home/abuild/rpmbuild/BUILD/sakura-3.1.2/build
[ 71s] + /usr/bin/make -j4 VERBOSE=1 V=1
[ 71s] /usr/bin/cmake -H/home/abuild/rpmbuild/BUILD/sakura-3.1.2 -B/home/abuild/rpmbuild/BUILD/sakura-3.1.2/build --check-build-system CMakeFiles/Makefile.cmake 0
[ 71s] /usr/bin/cmake -E cmake_progress_start /home/abuild/rpmbuild/BUILD/sakura-3.1.2/build/CMakeFiles /home/abuild/rpmbuild/BUILD/sakura-3.1.2/build/CMakeFiles/progress.marks
[ 71s] /usr/bin/make -f CMakeFiles/Makefile2 all
[ 71s] make[1]: Entering directory `/home/abuild/rpmbuild/BUILD/sakura-3.1.2/build'
[ 71s] /usr/bin/make -f CMakeFiles/man.dir/build.make CMakeFiles/man.dir/depend
[ 71s] /usr/bin/make -f CMakeFiles/sakura.dir/build.make CMakeFiles/sakura.dir/depend
[ 71s] /usr/bin/make -f po/CMakeFiles/translations.dir/build.make po/CMakeFiles/translations.dir/depend
[ 71s] make[2]: Entering directory `/home/abuild/rpmbuild/BUILD/sakura-3.1.2/build'
[ 71s] cd /home/abuild/rpmbuild/BUILD/sakura-3.1.2/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/abuild/rpmbuild/BUILD/sakura-3.1.2 /home/abuild/rpmbuild/BUILD/sakura-3.1.2 /home/abuild/rpmbuild/BUILD/sakura-3.1.2/build /home/abuild/rpmbuild/BUILD/sakura-3.1.2/build /home/abuild/rpmbuild/BUILD/sakura-3.1.2/build/CMakeFiles/man.dir/DependInfo.cmake --color=
[ 71s] make[2]: Entering directory `/home/abuild/rpmbuild/BUILD/sakura-3.1.2/build'
[ 71s] cd /home/abuild/rpmbuild/BUILD/sakura-3.1.2/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/abuild/rpmbuild/BUILD/sakura-3.1.2 /home/abuild/rpmbuild/BUILD/sakura-3.1.2 /home/abuild/rpmbuild/BUILD/sakura-3.1.2/build /home/abuild/rpmbuild/BUILD/sakura-3.1.2/build /home/...

[David Gómez (dabisu)]

I see, GtkAction are deprecated too in gtk 3.10. I'll open another bug for this. As for now please stick to gtk 3.8, i hope to fix this soon.

[DAP (darkness)]

Thanks! There are no possibility to stick in newer openSUSE release, but packages that were build for older one are fine with new gtk too.

[David Gómez (dabisu)]

Yes, is deprecated, so it should be compatible with all gtk versions up to version 4 (when is released). But it seems someone in the openSUSE latest release decided to compile gtk3 without support for deprecated symbols.

[DAP (darkness)]

Should I fill out a bug report?

[David Gómez (dabisu)]

It'd be good idea, but i don't know if this it's their policy and is an expected behaviour for openSUSE.

[DAP (darkness)]

Let's see: https://bugzilla.novell.com/show_bug.cgi?id=853227

[DAP (darkness)]

https://bugzilla.novell.com/show_bug.cgi?id=853227#c1
<q>
This looks like a mis-understanding from your end.

Were GTK built without GtkAction support, that would mean it would be binary
incompatible and any binary relying on it would crash.. clearly not the point.

What IS the case though is that GtkAction is deprecated and sakura defines in
the CmakeLists.txt thet deprecated symbols are not to be used.

This simple patch will help you build sakura, by allowing usage of deprecated
symbols (they are likely to stay around until GTK+ 4.0).

Cheers,

Index: sakura-3.1.2/CMakeLists.txt
===================================================================
--- sakura-3.1.2.orig/CMakeLists.txt
+++ sakura-3.1.2/CMakeLists.txt
@@ -38,7 +38,7 @@ ADD_DEFINITIONS (-DBUILDTYPE=\\\"${CMAKE
 IF (${CMAKE_BUILD_TYPE} MATCHES "Debug")
     SET (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall")
 ELSE (${CMAKE_BUILD_TYPE} NOT MATCHES "Debug")
- SET (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O2 -Wno-deprecated-declarations
-DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED")
+ SET (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O2 -Wno-deprecated-declarations")
 ENDIF (${CMAKE_BUILD_TYPE} MATCHES "Debug")

 INCLUDE_DIRECTORIES (. ${GTK_INCLUDE_DIRS} ${VTE_INCLUDE_DIRS})

[David Gómez (dabisu)]

Hey thanks, i forgot there was a no-deprecated in the CMakelists. It seems a very bad idea from my part, i'll remove it.

[Christoph Wickert (cwickert)]

This was fixed in http://bazaar.launchpad.net/~dabisu/sakura/sakura/revision/466 and released as 3.1.3, so I think this can be closed, right?

[Christoph Wickert (cwickert)]

Oh, it is, my bad. Sorry for the noise.