sahara cluster scaling validation error

[Shu Yingya]

After change 36f7ed8ecec74453e73dd328a273028e6a2a65dc (Add NGT resources validation before scaling cluster), sahara cluster will validate the resource in node groups before scaling. However, there are some configurations in node_configs(like "mapreduce.reduce.java.opts") which are not configurable. An existing cluster includes all configuration (sahara auto injected or user configured), so the validation will throw an exception.

ENV: master branch

Error Msg:
Plugin's applicable target 'MapReduce' doesn't contain config with name 'mapreduce.reduce.java.opts' Error ID: 4e16a9c3-c5c1-4c9a-953a-e67b561930fd

solution:
Node_groups object includes some configurations which are sahara code injected after validating. When scale a cluster, sahara should pass node_group_template object to method "check_node_group_basic_fields" other than node_groups object.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/526098

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/526098
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=e1b78b2bc7c152d7dc9ac7f010f3044365abd926
Submitter: Zuul
Branch: master

commit e1b78b2bc7c152d7dc9ac7f010f3044365abd926
Author: Shu Yingya <email address hidden>
Date: Wed Dec 6 15:07:06 2017 +0000

    Fix scaling validation error

    Sahara will validate resources when running scale cluster.
    But we shouldn't check all resources in node groups while scaling,
    because there are some configurations for MapReduce like
    'mapreduce.reduce.java.opts' in 'node_configs' which are
    added after validation.
    This patch changes to validate resource in "node group
    template" other than "node groups".

    Closes-Bug: #1736671
    Change-Id: I564b07cc4db275d4a369ce8cbff87cd6bda368fa

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/sahara 8.0.0.0b2 development milestone.