Sahara

[UI] Plugin version sorting not quite proper

Bug #1707204 reported by Jeremy Freudberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
Low
Jeremy Freudberg

Bug Description

In https://review.openstack.org/#/c/414807/ , we sorted plugin version so that the newest version would always come first.

But now, with CDH 5.11, it comes at the bottom because 1 < 9, even though 11 > 9.

Some minor tweaks need to be made to the sorting logic.

Jeremy Freudberg (jfreud)
Changed in sahara:
assignee: nobody → Jeremy Freudberg (jfreud)
Jeremy Freudberg (jfreud)
Changed in sahara:
importance: Undecided → Low
importance: Low → Medium
importance: Medium → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/504523

Changed in sahara:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara-dashboard (master)

Reviewed: https://review.openstack.org/504523
Committed: https://git.openstack.org/cgit/openstack/sahara-dashboard/commit/?id=ffe437171096c4b8589cb9d0fdc77d0af200e027
Submitter: Jenkins
Branch: master

commit ffe437171096c4b8589cb9d0fdc77d0af200e027
Author: Jeremy Freudberg <email address hidden>
Date: Fri Sep 15 21:03:25 2017 +0000

    Fix plugin version sorting

    Default sorting is not good enough, since it alphabetically sorts
    numbers, as in 11 < 2 instead of 11 > 10.

    Change-Id: Iaa575cf4ba0fe76524ba2823ce50de30a5b931d9
    Closes-Bug: #1707204

Changed in sahara:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara-dashboard (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/510617

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara-dashboard (stable/pike)

Reviewed: https://review.openstack.org/510617
Committed: https://git.openstack.org/cgit/openstack/sahara-dashboard/commit/?id=26b04834352a6dc9c4eceb5e53f32db381c2ffa6
Submitter: Jenkins
Branch: stable/pike

commit 26b04834352a6dc9c4eceb5e53f32db381c2ffa6
Author: Jeremy Freudberg <email address hidden>
Date: Fri Sep 15 21:03:25 2017 +0000

    Fix plugin version sorting

    Default sorting is not good enough, since it alphabetically sorts
    numbers, as in 11 < 2 instead of 11 > 10.

    Change-Id: Iaa575cf4ba0fe76524ba2823ce50de30a5b931d9
    Closes-Bug: #1707204
    (cherry picked from commit ffe437171096c4b8589cb9d0fdc77d0af200e027)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/sahara-dashboard 8.0.0.0b1

This issue was fixed in the openstack/sahara-dashboard 8.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/sahara-dashboard 7.0.1

This issue was fixed in the openstack/sahara-dashboard 7.0.1 release.

Luigi Toscano (ltoscano)
tags: added: dashboard
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.