Env vars in nested scripts lost in image gen CLI

Bug #1673120 reported by Elise Gafford
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
Undecided
Elise Gafford

Bug Description

Nesting our scripts within a second bash shell resulted
in an odd libguestfs issue in which environment variables
set within the script were not set. The nested scripting
was never truly necessary for any safety concern (as we
only ever set injected variables before the nested bash
command), and thus is now being removed.

Elise Gafford (egafford)
Changed in sahara:
assignee: nobody → Elise Gafford (egafford)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (master)

Fix proposed to branch: master
Review: https://review.openstack.org/446017

Changed in sahara:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/446017
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=f24dc4da726291df7b67847b2bd8e4ce378c2615
Submitter: Jenkins
Branch: master

commit f24dc4da726291df7b67847b2bd8e4ce378c2615
Author: Elise Gafford <email address hidden>
Date: Wed Mar 15 11:31:24 2017 -0400

    Fixing env vars within bash scripts for image gen

    Nesting our scripts within a second bash shell resulted
    in an odd libguestfs issue in which environment variables
    set within the script were not set. The nested scripting
    was never truly necessary for any safety concern (as we
    only ever set injected variables before the nested bash
    command), and thus is now being removed.

    Change-Id: I32c90aeb04acddeeb0e3307a7be4c8426fb0938c
    Closes-bug: #1673120

Changed in sahara:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/sahara 7.0.0.0b2

This issue was fixed in the openstack/sahara 7.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.