Must regenerate cluster template after node group template edit

Bug #1519871 reported by Chad Roberts
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
Medium
Chad Roberts

Bug Description

Currently, after you make an edit to a node group template, you also need to regenerate your cluster template. Otherwise, the cluster template will continue to carry the outdated node group template information. This is not ideal and is really an oversight/bug in the edit logic.

When a node group template is updated, any referencing cluster templates should also be updated to reference the updated node group template information.

Changed in sahara:
status: New → Triaged
importance: Undecided → Low
milestone: none → next
Chad Roberts (croberts)
Changed in sahara:
assignee: nobody → Chad Roberts (croberts)
Changed in sahara:
status: Triaged → In Progress
Changed in sahara:
milestone: next → mitaka-2
Changed in sahara:
importance: Low → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/254810
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=e7a130f1fde24866e4fa9e370e0e0026c5877acd
Submitter: Jenkins
Branch: master

commit e7a130f1fde24866e4fa9e370e0e0026c5877acd
Author: Chad Roberts <email address hidden>
Date: Mon Dec 7 15:45:08 2015 -0500

    Now updating cluster templates on update

    When a node group template is updated that is
    referenced by a cluster template, that cluster template
    is now updated so that the values shown to the user
    will be correct. Also adding a test for this scenario.

    Change-Id: I9b45e2806ee169e1b37dda0d06ca12da562fd67d
    Closes-Bug: #1519871

Changed in sahara:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (master)

Fix proposed to branch: master
Review: https://review.openstack.org/283778

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/283778
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=971566b9c318ad521ef629811cd41c37424a9eaa
Submitter: Jenkins
Branch: master

commit 971566b9c318ad521ef629811cd41c37424a9eaa
Author: Trevor McKay <email address hidden>
Date: Tue Feb 23 15:19:53 2016 -0500

    Missing ignore_prot_on_def flag

    When node_group_template_update() calls cluster_template_update(),
    it must propagate the ignore_prot_on_def flag (used by the
    sahara-templates tool). This is an additional patch to the
    bug fix.

    Change-Id: I6a9ed5434e170d7397318c7d684533b851501efd
    Closes-bug: #1519871

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/sahara 4.0.0.0b3

This issue was fixed in the openstack/sahara 4.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.