Sahara

New bashate release brings to Sahara too many warnings in scripts

Bug #1509271 reported by Vitalii Gridnev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
Wishlist
Michael Ionkin
Sahara mitaka-rc1 "RC1"
Kilo
Fix Released
Undecided
Unassigned
Liberty
Fix Released
Undecided
Unassigned
Vitalii Gridnev (vgridnev)
summary: - Need bashate release brings to Sahara too many warnings in scripts
+ New bashate release brings to Sahara too many warnings in scripts
Sergey Reshetnyak (sreshetniak)
Changed in sahara:
status: New → Triaged
importance: Undecided → Wishlist
milestone: none → next
Sergey Reshetnyak (sreshetniak)
tags: added: low-hanging-fruit
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/243277
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=368c2a8d36daee366ed551e1af365ec99ea0c150
Submitter: Jenkins
Branch: master

commit 368c2a8d36daee366ed551e1af365ec99ea0c150
Author: Sergey Reshetnyak <email address hidden>
Date: Mon Nov 9 22:30:19 2015 +0300

    Fix E005 bashate error

    Change-Id: Ia7a85ae5308e3fc095e84daf729ea082eedb9c1a
    Partial-bug: #1509271

Michael Ionkin (msionkin)
Changed in sahara:
assignee: nobody → Michael Ionkin (msionkin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (master)

Fix proposed to branch: master
Review: https://review.openstack.org/248822

Changed in sahara:
status: Triaged → In Progress
Vitalii Gridnev (vgridnev)
Changed in sahara:
milestone: next → mitaka-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/248822
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=c05e87f07b33265bcb2715bc38dcf2a5d70815fc
Submitter: Jenkins
Branch: master

commit c05e87f07b33265bcb2715bc38dcf2a5d70815fc
Author: msionkin <email address hidden>
Date: Mon Nov 23 17:24:08 2015 +0300

    Fix bashate warnings

    There were too many warnings in script. This patch fixes
    E006 (check for lines longer than 79 columns) and
    E042 (local declaration hides errors) bashate warnings.
    Except some long URLs because splitting them up
    doesn't increase code readability

    Change-Id: I7838a820c2acea8ac31b5108296bfa26a439ac71
    Partial-Bug: #1509271

Vitalii Gridnev (vgridnev)
Changed in sahara:
milestone: mitaka-1 → mitaka-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/283680

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on sahara (stable/liberty)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/282532
Reason: https://review.openstack.org/#/c/283680/ is the proper fix.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/283705

Vitalii Gridnev (vgridnev)
Changed in sahara:
milestone: mitaka-2 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (stable/liberty)

Reviewed: https://review.openstack.org/283680
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=72301b47e7a42f63b3fcdb9241ec71607dedaada
Submitter: Jenkins
Branch: stable/liberty

commit 72301b47e7a42f63b3fcdb9241ec71607dedaada
Author: Sergey Reshetnyak <email address hidden>
Date: Mon Nov 9 22:30:19 2015 +0300

    Fix E005 bashate error

    Change-Id: Ia7a85ae5308e3fc095e84daf729ea082eedb9c1a
    Partial-bug: #1509271
    (cherry picked from commit 368c2a8d36daee366ed551e1af365ec99ea0c150)

    -- squashed with another change --

    Revert "Fix gate pep8"

    pep8 gate fixed correctly, original commit breaks MapR plugin

    This reverts commit 025d759c558ae954e31dc8d7b34f667b4506284c.

    ----

    NOTE(mriedem): Also have to fix ecosystem_test_script.sh
    which is not in master.

    Closes-Bug: #1547670

    Change-Id: I0a7d9562c9c08236e5f1b0606a157836bbf0dd49
    (cherry picked from commit eac731f6bc3de1f74fe2612b6740572736baf31f)

tags: added: in-stable-liberty
tags: added: in-stable-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (stable/kilo)

Reviewed: https://review.openstack.org/283705
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=d44dd33f99f1a946fa84a5fa3701465f5dea9e32
Submitter: Jenkins
Branch: stable/kilo

commit d44dd33f99f1a946fa84a5fa3701465f5dea9e32
Author: Sergey Reshetnyak <email address hidden>
Date: Mon Nov 9 22:30:19 2015 +0300

    Fix E005 bashate error

    Change-Id: Ia7a85ae5308e3fc095e84daf729ea082eedb9c1a
    Partial-bug: #1509271
    (cherry picked from commit 368c2a8d36daee366ed551e1af365ec99ea0c150)

    -- squashed with another change --

    Revert "Fix gate pep8"

    pep8 gate fixed correctly, original commit breaks MapR plugin

    This reverts commit 025d759c558ae954e31dc8d7b34f667b4506284c.

    ----

    NOTE(mriedem): Also have to fix ecosystem_test_script.sh
    which is not in master.

    Conflicts:
            devstack/settings
            devstack/upgrade/settings
            tox.ini

    NOTE(mriedem): The devstack and tox.ini changes are not
    carried over to stable/kilo since they don't exist in
    kilo and are thus not applicable.

    Closes-Bug: #1547670

    Change-Id: I0a7d9562c9c08236e5f1b0606a157836bbf0dd49
    (cherry picked from commit eac731f6bc3de1f74fe2612b6740572736baf31f)
    (cherry picked from commit 72301b47e7a42f63b3fcdb9241ec71607dedaada)

Vitalii Gridnev (vgridnev)
Changed in sahara:
milestone: next → mitaka-rc1
status: In Progress → Fix Released
Vitalii Gridnev (vgridnev)
tags: removed: in-stable-kilo
tags: removed: in-stable-liberty
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.