Sample Sahara cluster with Vanilla Hadoop plugin fails

[Ashish Billore]

try deploying a sample Sahara cluster with Vanilla Hadoop Plugin, following this link: http://docs.openstack.org/developer/sahara/devref/quickstart.html.

Everything goes fine, except the end part:

$ sahara cluster-create --json cluster_create.json

Here it bombs with:

 ¨ERROR: Internal Server Error¨

In logs the traces are:

2015-08-31 12:05:05.517 4904 INFO sahara.utils.cluster [req-18d89f78-a569-4474-aac5-67e52a10d99c ] [instance: none, cluster: 0a1dc412-6fa0-4603-b82b-717b555ff59b] Cluster status has been changed. New status=Error
2015-08-31 12:05:05.518 4904 ERROR sahara.utils.api [req-18d89f78-a569-4474-aac5-67e52a10d99c ] [instance: none, cluster: 0a1dc412-6fa0-4603-b82b-717b555ff59b] Request aborted with status code 500 and message 'Internal Server Error'
2015-08-31 12:05:05.518 4904 ERROR sahara.utils.api [req-18d89f78-a569-4474-aac5-67e52a10d99c ] [instance: none, cluster: 0a1dc412-6fa0-4603-b82b-717b555ff59b] Traceback (most recent call last):
  File "/opt/stack/sahara/sahara/utils/api.py", line 97, in handler
    return func(**kwargs)
  File "/opt/stack/sahara/sahara/api/acl.py", line 44, in handler
    return func(*args, **kwargs)
  File "/opt/stack/sahara/sahara/service/validation.py", line 47, in handler
    return func(*args, **kwargs)
  File "/opt/stack/sahara/sahara/api/v10.py", line 51, in clusters_create
    return u.render(api.create_cluster(data).to_wrapped_dict())
  File "/opt/stack/sahara/sahara/service/api.py", line 103, in create_cluster
    return _cluster_create(values, plugin)
  File "/opt/stack/sahara/sahara/service/api.py", line 142, in _cluster_create
    cluster, c_u.CLUSTER_STATUS_ERROR, six.text_type(e))
  File "/usr/local/lib/python2.7/dist-packages/oslo_utils/excutils.py", line 195, in __exit__
    six.reraise(self.type_, self.value, self.tb)
  File "/opt/stack/sahara/sahara/service/api.py", line 134, in _cluster_create
    plugin.recommend_configs(cluster)
  File "/opt/stack/sahara/sahara/plugins/vanilla/plugin.py", line 98, in recommend_configs
    cluster.hadoop_version).recommend_configs(cluster, scaling)
TypeError: recommend_configs() takes exactly 2 arguments (3 given)

2015-08-31 12:05:05.519 4904 INFO sahara.utils.wsgi [-] - - [31/Aug/2015 12:05:05] "POST /v1.1/c82e4bce56ce4cf9b90bd15dfdef699d/clusters HTTP/1.1" 500 318 1.163123

Issue is traced to the plan to depricate Hadoop version 1.x in Liberty.

Version info:

 sahara --version
0.10.1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/219565

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/219565
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=c78844a875dcc428086059d3ae9b2c09bf3c5c7b
Submitter: Jenkins
Branch: master

commit c78844a875dcc428086059d3ae9b2c09bf3c5c7b
Author: mathspanda <email address hidden>
Date: Wed Sep 2 13:47:11 2015 +0800

    Modify recommend_configs arguments in vanilla 1

    Although recommentdations in vanilla 1 plugin aren't supported, the
    arguments of method recommend_configs in versionhandler should be
    consistent with version 2. Otherwise, the creation of cluster will
    fail with Internal Server Error.

    Change-Id: Ic0b6fcc4cd51bcc4095a2e3f9db80abb40b415d7
    Closes-Bug: #1490723