resource updating methods should be using PATCH instead of PUT

Bug #1481825 reported by Michael McCune
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Invalid
Undecided
Unassigned

Bug Description

there are currently a few methods for updating resources in sahara that use PUT with a partial resource update. while this works, it would be more accurate to make them PATCH methods. this change should occur in both the sahara controller and the saharaclient packages.

the problem being addressed here is that there are 2 different methodologies in use within sahara for updating objects and it creates a confusing view of the REST API. by making these all use PATCH it will be more clear the intended usage of the methods.

the affected methods are for updating node group templates, cluster templates, job binaries, and data sources.

for reference on partial updating, see https://tools.ietf.org/html/rfc5789

description: updated
willy lin (willy-l)
Changed in sahara:
assignee: nobody → willy lin (willy-l)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (master)

Fix proposed to branch: master
Review: https://review.openstack.org/212917

Changed in sahara:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on sahara (master)

Change abandoned by willy lin (<email address hidden>) on branch: master
Review: https://review.openstack.org/212917

willy lin (willy-l)
Changed in sahara:
assignee: willy lin (willy-l) → nobody
Revision history for this message
Chad Roberts (croberts) wrote :

I believe the consensus on this was that we will leave the PUTs alone for now. In api v2, these operations will be PATCH.

Changed in sahara:
importance: Undecided → Wishlist
status: In Progress → Triaged
Revision history for this message
Sergey Reshetnyak (sreshetniak) wrote :

This bug is > 60 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in sahara:
status: Triaged → Incomplete
Revision history for this message
Vitalii Gridnev (vgridnev) wrote :
Changed in sahara:
status: Incomplete → Won't Fix
status: Won't Fix → Invalid
importance: Wishlist → Undecided
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.