After updating cluster template info about node groups missed

Bug #1438077 reported by Vitalii Gridnev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
Medium
Trevor McKay
Kilo
Fix Released
High
Vitalii Gridnev

Bug Description

Steps to reproduce:

1) create cluster template with 2 node groups
2) try to update cluster template via conductor:

conductor.cluster_template_update(context.ctx(), cluster_template_id, {'name': "some_name"})

Expected result:
 name updated and cluster template still contain 2 node groups

Observed result:
 name updated and cluster template doesn't have any info about node groups

Changed in sahara:
assignee: nobody → Vitaly Gridnev (vgridnev)
Changed in sahara:
assignee: Vitaly Gridnev (vgridnev) → nobody
Trevor McKay (tmckay)
Changed in sahara:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Trevor McKay (tmckay)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (master)

Fix proposed to branch: master
Review: https://review.openstack.org/182783

Changed in sahara:
status: Confirmed → In Progress
Trevor McKay (tmckay)
Changed in sahara:
milestone: none → liberty-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/182783
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=196f72f18e7c5649580a7746b87e35defaadb943
Submitter: Jenkins
Branch: master

commit 196f72f18e7c5649580a7746b87e35defaadb943
Author: Trevor McKay <email address hidden>
Date: Wed May 13 14:24:14 2015 -0400

    Fix cluster templates update

    This change fixes the following issues:

    * Remove _appy_defaults for cluster template fields on update
      Fields that are not specified should not be given default values
      on update like they are on creation. If a field is not specified,
      it should be left alone

    * Do not delete node groups if the cluster template update does
      specify a node_group field

    Closes-Bug: #1438077
    Change-Id: I65dd15e02871f9c7227d2b51acedd6e06cb04950

Changed in sahara:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/181477
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=0ba7ece84f67d6ffb88a5d01b9532b67d9a9bc9d
Submitter: Jenkins
Branch: master

commit 0ba7ece84f67d6ffb88a5d01b9532b67d9a9bc9d
Author: Trevor McKay <email address hidden>
Date: Fri May 8 13:26:24 2015 -0400

    Add "null" for fields in cluster and node group template JSON schemas

    * Change 'type' for optional fields to list including 'null'

    * Allow the default template tool to use "None" to
    unset fields with replacement values when no replacement has been
    specified.

    * Fix cluster template update code to check for explicit setting of
    the 'node_groups' field in a cluster template update

    Partial-Bug: #1438077
    Closes-Bug: #1439839

    Change-Id: Ia180867c8e3ffb502da40f169a49dd3a54c23072

Thierry Carrez (ttx)
Changed in sahara:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/195998

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on sahara (stable/kilo)

Change abandoned by Vitaly Gridnev (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/195998

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (stable/kilo)

Reviewed: https://review.openstack.org/195998
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=2495f1af8504511ce39fda032ce2fa3e021f2b81
Submitter: Jenkins
Branch: stable/kilo

commit 2495f1af8504511ce39fda032ce2fa3e021f2b81
Author: Trevor McKay <email address hidden>
Date: Wed May 13 14:24:14 2015 -0400

    Fix cluster templates update

    This change fixes the following issues:

    * Remove _appy_defaults for cluster template fields on update
      Fields that are not specified should not be given default values
      on update like they are on creation. If a field is not specified,
      it should be left alone

    * Do not delete node groups if the cluster template update does
      specify a node_group field

    Closes-Bug: #1438077
    Change-Id: I65dd15e02871f9c7227d2b51acedd6e06cb04950
    (cherry picked from commit 196f72f18e7c5649580a7746b87e35defaadb943)

Thierry Carrez (ttx)
Changed in sahara:
milestone: liberty-1 → 3.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.