Bug #1391536 “Delete cluster without security groups failed” : Bugs : Sahara

Revision history for this message

Sergey Lukjanov (slukjanov) wrote on 2014-11-11: Re: [Bug 1391536] [NEW] Delete cluster without security groups failed

#1

Download full text (5.2 KiB)

Probably we'll need to backport it to Juno, isn't it?

On Tuesday, November 11, 2014, Sergey Reshetnyak <email address hidden>
wrote:

> Public bug reported:
>
> 1. Create cluster with auto security groups. Creating cluster failed and
> security groups not created.
> 2. Try delete cluster.
> 3. Get an error:
>
> 2014-11-11 17:40:37.585 2628 INFO sahara.utils.general [-] Cluster status
> has been changed: id=1221cb5e-23b1-46d0-9018-b291bceef60e, New
> status=Deleting
> 2014-11-11 17:40:37.586 2628 INFO sahara.cli.sahara_all [-] 127.0.0.1 - -
> [11/Nov/2014 17:40:37] "DELETE
> /v1.1/8e44eb2ce32b4c72b82070abbcd61ba8/clusters/1221cb5e-23b1-46d0-9018-b291bceef60e
> HTTP/1.1" 204 139 0.077875
> 2014-11-11 17:40:37.656 2628 ERROR sahara.service.ops [-] Error during
> operating cluster 'sr-template-test' (reason: 'NoneType' object has no
> attribute '__getitem__')
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops Traceback (most
> recent call last):
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops File
> "/home/serg/projects/sahara/sahara/service/ops.py", line 141, in wrapper
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops f(cluster_id,
> *args, **kwds)
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops File
> "/home/serg/projects/sahara/sahara/service/ops.py", line 284, in
> terminate_cluster
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops
> INFRA.shutdown_cluster(cluster)
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops File
> "/home/serg/projects/sahara/sahara/service/direct_engine.py", line 488, in
> shutdown_cluster
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops
> self._shutdown_instances(cluster)
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops File
> "/home/serg/projects/sahara/sahara/service/direct_engine.py", line 447, in
> _shutdown_instances
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops
> self._delete_auto_security_group(node_group)
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops File
> "/home/serg/projects/sahara/sahara/service/direct_engine.py", line 453, in
> _delete_auto_security_group
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops name =
> node_group.security_groups[-1]
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops TypeError:
> 'NoneType' object has no attribute '__getitem__'
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops
>
> ** Affects: sahara
> Importance: Medium
> Status: Confirmed
>
> --
> You received this bug notification because you are subscribed to Sahara.
> https://bugs.launchpad.net/bugs/1391536
>
> Title:
> Delete cluster without security groups failed
>
> Status in OpenStack Data Processing (Sahara, ex. Savanna):
> Confirmed
>
> Bug description:
> 1. Create cluster with auto security groups. Creating cluster failed and
> security groups not created.
> 2. Try delete cluster.
> 3. Get an error:
>
> 2014-11-11 17:40:37.585 2628 INFO sahara.utils.general [-] Cluster
> status has been changed: id=1221cb5e-23b1-46d0-9018-b291bceef60e, New
> status=Deleting
> 2014-11-11 17:40:37.586 2628 INFO sahara.cli.sahara_all [-] 127.0.0.1 -
> - [11/Nov/2014 17:40:37] "DELETE
> /v1.1/8e4...

Probably we'll need to backport it to Juno, isn't it?

On Tuesday, November 11, 2014, Sergey Reshetnyak <sreshetniak@mirantis.com>
wrote:

> Public bug reported:
>
> 1. Create cluster with auto security groups. Creating cluster failed and
> security groups not created.
> 2. Try delete cluster.
> 3. Get an error:
>
> 2014-11-11 17:40:37.585 2628 INFO sahara.utils.general [-] Cluster status
> has been changed: id=1221cb5e-23b1-46d0-9018-b291bceef60e, New
> status=Deleting
> 2014-11-11 17:40:37.586 2628 INFO sahara.cli.sahara_all [-] 127.0.0.1 - -
> [11/Nov/2014 17:40:37] "DELETE
> /v1.1/8e44eb2ce32b4c72b82070abbcd61ba8/clusters/1221cb5e-23b1-46d0-9018-b291bceef60e
> HTTP/1.1" 204 139 0.077875
> 2014-11-11 17:40:37.656 2628 ERROR sahara.service.ops [-] Error during
> operating cluster 'sr-template-test' (reason: 'NoneType' object has no
> attribute '__getitem__')
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops Traceback (most
> recent call last):
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops   File
> "/home/serg/projects/sahara/sahara/service/ops.py", line 141, in wrapper
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops     f(cluster_id,
> *args, **kwds)
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops   File
> "/home/serg/projects/sahara/sahara/service/ops.py", line 284, in
> terminate_cluster
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops
>  INFRA.shutdown_cluster(cluster)
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops   File
> "/home/serg/projects/sahara/sahara/service/direct_engine.py", line 488, in
> shutdown_cluster
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops
>  self._shutdown_instances(cluster)
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops   File
> "/home/serg/projects/sahara/sahara/service/direct_engine.py", line 447, in
> _shutdown_instances
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops
>  self._delete_auto_security_group(node_group)
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops   File
> "/home/serg/projects/sahara/sahara/service/direct_engine.py", line 453, in
> _delete_auto_security_group
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops     name =
> node_group.security_groups[-1]
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops TypeError:
> 'NoneType' object has no attribute '__getitem__'
> 2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops
>
> ** Affects: sahara
>      Importance: Medium
>          Status: Confirmed
>
> --
> You received this bug notification because you are subscribed to Sahara.
> https://bugs.launchpad.net/bugs/1391536
>
> Title:
>   Delete cluster without security groups failed
>
> Status in OpenStack Data Processing (Sahara, ex. Savanna):
>   Confirmed
>
> Bug description:
>   1. Create cluster with auto security groups. Creating cluster failed and
> security groups not created.
>   2. Try delete cluster.
>   3. Get an error:
>
>   2014-11-11 17:40:37.585 2628 INFO sahara.utils.general [-] Cluster
> status has been changed: id=1221cb5e-23b1-46d0-9018-b291bceef60e, New
> status=Deleting
>   2014-11-11 17:40:37.586 2628 INFO sahara.cli.sahara_all [-] 127.0.0.1 -
> - [11/Nov/2014 17:40:37] "DELETE
> /v1.1/8e44eb2ce32b4c72b82070abbcd61ba8/clusters/1221cb5e-23b1-46d0-9018-b291bceef60e
> HTTP/1.1" 204 139 0.077875
>   2014-11-11 17:40:37.656 2628 ERROR sahara.service.ops [-] Error during
> operating cluster 'sr-template-test' (reason: 'NoneType' object has no
> attribute '__getitem__')
>   2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops Traceback (most
> recent call last):
>   2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops   File
> "/home/serg/projects/sahara/sahara/service/ops.py", line 141, in wrapper
>   2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops     f(cluster_id,
> *args, **kwds)
>   2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops   File
> "/home/serg/projects/sahara/sahara/service/ops.py", line 284, in
> terminate_cluster
>   2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops
>  INFRA.shutdown_cluster(cluster)
>   2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops   File
> "/home/serg/projects/sahara/sahara/service/direct_engine.py", line 488, in
> shutdown_cluster
>   2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops
>  self._shutdown_instances(cluster)
>   2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops   File
> "/home/serg/projects/sahara/sahara/service/direct_engine.py", line 447, in
> _shutdown_instances
>   2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops
>  self._delete_auto_security_group(node_group)
>   2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops   File
> "/home/serg/projects/sahara/sahara/service/direct_engine.py", line 453, in
> _delete_auto_security_group
>   2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops     name =
> node_group.security_groups[-1]
>   2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops TypeError:
> 'NoneType' object has no attribute '__getitem__'
>   2014-11-11 17:40:37.656 2628 TRACE sahara.service.ops
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/sahara/+bug/1391536/+subscriptions
>

-- 
Sincerely yours,
Sergey Lukjanov
Sahara Technical Lead
(OpenStack Data Processing)
Principal Software Engineer
Mirantis Inc.

Revision history for this message

Andrew Lazarev (alazarev) wrote on 2014-11-11:

#2

It is not too critical since deletion failure occurs only after creation failure. But, it would be good to backport to Juno.

Revision history for this message

Sergey Reshetnyak (sreshetniak) wrote on 2014-11-12:

#3

logs: http://paste.openstack.org/show/132346/

Changed in sahara:
importance:	Medium → High

Andrew Lazarev (alazarev) on 2014-11-12

Changed in sahara:
assignee:	nobody → Andrew Lazarev (alazarev)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-11-13: Fix proposed to sahara (master)

#4

Fix proposed to branch: master
Review: https://review.openstack.org/134345

Changed in sahara:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-11-18: Fix merged to sahara (master)

#5

Reviewed: https://review.openstack.org/134345
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=912cd351942eb442024e9b881e639b8f780f7138
Submitter: Jenkins
Branch: master

commit 912cd351942eb442024e9b881e639b8f780f7138
Author: Andrew Lazarev <email address hidden>
Date: Thu Nov 13 11:44:11 2014 -0800

Fixed auto security group cleanup in case of creation error

Change-Id: I4b025442ddc4d2433d4a537508d3b1d3b8e64592
Closes-Bug: #1391536

Changed in sahara:
status:	In Progress → Fix Committed

Thierry Carrez (ttx) on 2014-12-17

Changed in sahara:
status:	Fix Committed → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-01-28: Fix proposed to sahara (stable/juno)

#6

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/150820

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-03-16: Fix merged to sahara (stable/juno)

#7

Reviewed: https://review.openstack.org/150820
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=b88a8c2e1f329976cb78f378403fdbc6561dc282
Submitter: Jenkins
Branch: stable/juno

commit b88a8c2e1f329976cb78f378403fdbc6561dc282
Author: Andrew Lazarev <email address hidden>
Date: Thu Nov 13 11:44:11 2014 -0800

Fixed auto security group cleanup in case of creation error

    Change-Id: I4b025442ddc4d2433d4a537508d3b1d3b8e64592
    Closes-Bug: #1391536
    (cherry picked from commit 912cd351942eb442024e9b881e639b8f780f7138)

Thierry Carrez (ttx) on 2015-04-30

Changed in sahara:
milestone:	kilo-1 → 2015.1.0

Sahara

Delete cluster without security groups failed

Bug Description

Other bug subscribers

Remote bug watches

Affects		Status	Importance	Assigned to	Milestone
	Sahara	Fix Released	High	Andrew Lazarev	Sahara 2015.1.0 "kilo"
	Juno	Fix Released	High	Nikita Konovalov	Sahara 2014.2.3