[IT] Flag SKIP_ALL_TESTS_FOR_PLUGIN does not work

[Yaroslav Lobankov]

If config file has flag SKIP_ALL_TESTS_FOR_PLUGIN set to True but it doesn't have image related parameters, integration tests will fail. This failure occurs for Vanilla2 and IDH tests.
Trace is
======================================================================
FAIL: tests.gating.test_vanilla_two_gating.VanillaTwoGatingTest.test_vanilla_two_plugin_gating[vanilla2]
tags: worker-0
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ylobankov/Sahara/master/sahara/sahara/tests/integration/tests/gating/test_vanilla_two_gating.py", line 57, in setUp
    = (self.get_image_id_and_ssh_username(self.vanilla_two_config))
  File "sahara/tests/integration/tests/base.py", line 493, in get_image_id_and_ssh_username
    '\n\nNone of parameters of image (ID, name, tag) was specified in '
  File "/home/ylobankov/Sahara/master/sahara/.tox/integration/local/lib/python2.7/site-packages/unittest2/case.py", line 415, in fail
    raise self.failureException(msg)
AssertionError:
None of parameters of image (ID, name, tag) was specified in configuration file of integration tests. That is why there was attempt to choose image by tag "sahara_i_tests" but image with such tag not found in list of registered images for Sahara. Please, make sure image was correctly registered. Please, specify one of parameters of image (ID, name or tag) in configuration file of integration tests.

Test for Vanilla1 is skipped but testr shows this skipped test as error.
Trace is
======================================================================
FAIL: tests.gating.test_vanilla_gating.VanillaGatingTest.test_vanilla_plugin_gating[transient,vanilla1]
tags: worker-0
----------------------------------------------------------------------
Traceback (most recent call last):
SkipTest: All tests for Vanilla plugin were skipped

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/84417
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=941d87562cd0f55cc441769cea75d5b5154aa38e
Submitter: Jenkins
Branch: master

commit 941d87562cd0f55cc441769cea75d5b5154aa38e
Author: skostiuchenkoHDP <email address hidden>
Date: Tue Apr 1 14:44:52 2014 +0300

    Fixed tests failures when SKIP_ALL_TESTS_FOR_PLUGIN=True

    Moved skipif statement to be called before SetUp function in tests for IDH2
    and VANILLA_TWO plugins to avoid failures caused by call to
    get_image_id_and_ssh_username function in SetUp function.
    The fix makes test skipped instead of being failed.

    Co-Authored-By: Sergey Reshetnyak <email address hidden>

    Fixes bug: #1301273

    Change-Id: I5e2f67b7dd48c268f62fe94374e96a61e85aff18

[Thierry Carrez (ttx)]

This was actually merged after the MP branch cut.