[data-locality] Savanna crashes if topology file contains newline at the end

[Andrew Lazarev]

2014-01-22 16:02:50.294 8554 ERROR savanna.service.api [-] Can't configure cluster 'al-data-locality' (reason: need more than 0 values to unpack)
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api Traceback (most recent call last):
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api File "/Users/andrew/Savanna/savanna/savanna/service/api.py", line 209, in _provision_cluster
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api plugin.configure_cluster(cluster)
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api File "/Users/andrew/Savanna/savanna/savanna/plugins/vanilla/plugin.py", line 116, in configure_cluster
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api self._setup_instances(cluster, instances)
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api File "/Users/andrew/Savanna/savanna/savanna/plugins/vanilla/plugin.py", line 270, in _setup_instances
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api extra = self._extract_configs_to_extra(cluster)
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api File "/Users/andrew/Savanna/savanna/savanna/plugins/vanilla/plugin.py", line 210, in _extract_configs_to_extra
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api cluster, CONF.enable_hypervisor_awareness)
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api File "/Users/andrew/Savanna/savanna/savanna/topology/topology_helper.py", line 106, in generate_topology_map
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api mapping = _read_compute_topology()
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api File "/Users/andrew/Savanna/savanna/savanna/topology/topology_helper.py", line 91, in _read_compute_topology
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api (host, path) = line.split()
2014-01-22 16:02:50.294 8554 TRACE savanna.service.api ValueError: need more than 0 values to unpack

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/68525
Committed: https://git.openstack.org/cgit/openstack/savanna/commit/?id=21641ee35394229d53d3fab79737900ace36081c
Submitter: Jenkins
Branch: master

commit 21641ee35394229d53d3fab79737900ace36081c
Author: Andrew Lazarev <email address hidden>
Date: Wed Jan 22 16:10:59 2014 -0800

    Fixed reading topology file with newline at the end

    Closes-bug: #1271776

    Change-Id: I95ea0d785b294a179daad124e0073a8c3cc6a8ee

[Sergey Lukjanov (slukjanov)]

Fixed in i3