notator.cc:337: abs on unsigned value
Bug #1413108 reported by
dcb
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
rumor |
Fix Committed
|
Undecided
|
Unassigned | ||
Arch Linux |
New
|
Undecided
|
Unassigned |
Bug Description
notator.cc:337:16: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value]
NumTics=
The difference of two unsigneds is unsigned.
If RefPitch_wt < AbsPitch_wt, then wraparound to a large unsigned integer will occur.
Suggest code rework.
To post a comment you must log in.
Gcc 7 changes the way abs is handled.
The attached patch at least makes rumor build again.