rpmio/bson.h provide MONGO_INLINE and MONGO_EXPORT defines for Studio

[Tim Mooney]

rpm-5.4.12 on x86_64-pc-solaris2.11 (OpenIndiana oi151a8) with the Oracle Studio 12.3 compiler.

rpmio/bson.h appears to assume either GCC or Windows, so when using a non-gcc compiler the incorrect defines for MONGO_INLINE and expecially MONGO_EXPORT cause compilation problems.

source='bson.c' object='bson.lo' libtool=yes \
        DEPDIR=.deps depmode=none /bin/sh ../depcomp \
        /bin/sh ../libtool --tag=CC --mode=compile cc -m64 -DHAVE_CONFIG_H -I. -I.. -I. -I.. -I../build -I../lib -I../lib -I../rpmdb -I../rpmio -I../misc -I../beecrypt/include -I../beecrypt/include -I../beecrypt -I../beecrypt -I../popt -I../popt -D__FUNCTION__=__func__ -I/local/gnu/include -I/local/include -I/local/include/neon -I/local/include/beecrypt -I/local/openssl/include -DRPM_OS_SOLARIS=021100 -I/local/include/db60 -I/usr/include/pcre -xopenmp -Xa -xc99=all -xO3 -g -mt -KPIC -D__FUNCTION__=__func__ -m64 -I/local/gnu/include -I/local/include -I/local/include/neon -I/local/include/beecrypt -I/local/openssl/include -D_GNU_SOURCE -D_REENTRANT -c -o bson.lo bson.c
libtool: compile: cc -m64 -DHAVE_CONFIG_H -I. -I.. -I. -I.. -I../build -I../lib -I../lib -I../rpmdb -I../rpmio -I../misc -I../beecrypt/include -I../beecrypt/include -I../beecrypt -I../beecrypt -I../popt -I../popt -D__FUNCTION__=__func__ -I/local/gnu/include -I/local/include -I/local/include/neon -I/local/include/beecrypt -I/local/openssl/include -DRPM_OS_SOLARIS=021100 -I/local/include/db60 -I/usr/include/pcre -xopenmp -Xa -xc99=all -xO3 -g -mt -KPIC -D__FUNCTION__=__func__ -m64 -I/local/gnu/include -I/local/include -I/local/include/neon -I/local/include/beecrypt -I/local/openssl/include -D_GNU_SOURCE -D_REENTRANT -c bson.c -KPIC -DPIC -o .libs/bson.o
"bson.h", line 156: warning: old-style declaration or incorrect type for: __declspec
"bson.h", line 156: parameter not in identifier list: bson_init_zero
"bson.h", line 167: warning: no explicit type given for parameter: dllimport
"bson.h", line 167: syntax error before or at: __declspec
"bson.h", line 167: warning: old-style declaration or incorrect type for: __declspec
"bson.h", line 167: identifier redefined: __declspec

[ and so on, for pages ]

The fix is to provide suitable defines for MONGO_INLINE and especially MONGO_EXPORT

A possible patch is attached.

[Jeff Johnson (n3npq)]

Applied: thanks for the patch.