Serbian KDE translations mixed-up

[Данило Шеган]

Since Lucid, Serbian KDE users have experienced problems with Јеkavian translations appearing instead of Serbian Cyrillic.

A few example discussions (all in Serbian) which include a few screenshots: http://www.ubuntu-rs.org/forum/Thread-Izmesan-prevod-u-Lucid-u and http://www.ubuntu-rs.org/forum/Thread-Reseno-KDE-4-5-i-srpski-prevod

I've confirmed the problem on https://translations.launchpad.net/ubuntu/maverick/+source/kde4libs/+pots/kdelibs4/sr/+translate?batch=10&show=all&search=Full+screen

It could be that Launchpad logic for figuring out the language code from KDE l10n packages is broken, so I'll add a Launchpad task as well.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r12107 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12107>.

[Данило Шеган (danilo)]

Ok, I've tried QAing this with the help from William Grant. FWIW, I've had trouble QAing because none of the languages was 'visible'. What we'll probably need to do to make this work is to either unset language code (to keep the behaviour current code is designed to have) when a variant language is seen, or simply to also approve for hidden languages as well.

[Данило Шеган (danilo)]

The fix is no worse off than it used to be, but it sometimes works badly when the language is hidden (i.e. it approves stuff into a wrong language). It doesn't happen every time.

[Данило Шеган (danilo)]

Ok, so I figured what the problem was: when PO files exist in the database with matching paths (i.e. due to previous buggy behaviour, a Serbian PO file might have "sr@latin" in the path), the file is matched against it and thus misapproved. We'll have to clean up these in the DB.

[Данило Шеган (danilo)]

Path is given precedence as well, so we'll have to fix them first. At least it's updated to the new path once it's properly matched up.

SQL for cleaning up broken paths: https://pastebin.canonical.com/41276/

[Данило Шеган (danilo)]

Fixed code is out. Clean-up SQL will be run shortly, and then we need to re-import all KDE Serbian translations.