Reviewing suggestions without changing translations

Bug #225712 reported by Jeroen T. Vermeulen
8
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Henning Eggers

Bug Description

A "new suggestion" is one that was submitted since its message's last review. As long as subsequent review leaves the message's translation as it is, the suggestion stays "new." This can be a nuisance for reviewers who have no way to clear out bad suggestions.

The easy way to fix this would be to update a message's review date whenever a reviewer submits a page it's in, regardless of whether the request changes the message. That may cause suggestions to be lost, however.

Changed in rosetta:
importance: Undecided → High
Revision history for this message
Adi Roiban (adiroiban) wrote :

Can this feature be linked to " Someone should review this translation" ?

If a reviewer wants to reset or keep the current "new" state of translation he/she can tick or untick this checkbox

Revision history for this message
Adi Roiban (adiroiban) wrote :

Any news about this bug?

I',m trying to define some review steps for my team and this bug is very annoying, especially for normal team members who don't know to much about Rosetta.

Cheers!

Revision history for this message
Данило Шеган (danilo) wrote :

We are avoiding to add more UI clutter. We'll have a UI sprint in about a month, and I'll make sure we raise this as well.

Also, note that there's a workaround for you: copy the current translation (put it somewhere where you can copy it back from), choose any other suggestion and submit, then go back to the same message and paste old translation. This will invalidate all the suggestions and will act similarly to what we want to do as a solution (except that we need to figure out UI for it).

Note that "Someone should review this translation" allows reviewers to send only a suggestion (non-reviewers don't see that), and reusing it for something else would make it only more confusing.

Changed in rosetta:
status: New → Triaged
Revision history for this message
Dirk Stöcker (stoecker) wrote :

Please please fix that bug! UI clutter or not. I today again had to handle 50 translations. It is a mess.

- Select the text to fix as individual translation (click on magnifying glass)
- Select the text I want to save using the mouse.
- Remove the text from the dialog (as selecting usually also causes the text to be activated)
- Press OK
- Press Back
- Enter text
- Press OK

Takes long and is a lot of work.

What about this solution:
- Add one check button which says "I checked everything on this page, clear all suggestion marks".

- Don't remove old texts or suggestions immediatelly. There should be a possibility to access them even if the are not handled as new suggestions. I can access stuff from other packages and old upstream translations, but there is no way to access older texts of the current project. They should at least be keep for a time (e.g. 1 month).

Revision history for this message
Dirk Stöcker (stoecker) wrote :

BTW:

Why doesn't copying the old text as new text solve the issue?
Shouldn't these two case be distinguishable?

Revision history for this message
Данило Шеган (danilo) wrote : Re: [Bug 225712] Re: Reviewing suggestions without changing translations

У уто, 10. 02 2009. у 18:11 +0000, Dirk Stöcker пише:
>
> Why doesn't copying the old text as new text solve the issue?
> Shouldn't these two case be distinguishable?

That would be very subtle (which makes it hard to discover, and can lead
to mistakes), but is an idea to consider.

It's less than a month before we meet up to discuss these UI issues, and
as I said, we'll cover this one as well.

Revision history for this message
Dirk Stöcker (stoecker) wrote :

This bug is now 9 months old and has high priority. Is there any progress?

I have at least 60 suggestions I would like to get rid of and other language translations in my projects probably have some hundreds. Not beeing able to cancel suggestions makes the suggestions feature nearly worthless for me, because I don't have the time to rereview all the old texts.

Revision history for this message
Данило Шеган (danilo) wrote :

There has been some progress: UI has been discussed and decided on, and we'll work on this in the coming months (there's a lot of high priority stuff that's happening at the same time).

Changed in rosetta:
assignee: nobody → Henning Eggers (henninge)
status: Triaged → In Progress
Changed in rosetta:
milestone: none → 2.2.6
Revision history for this message
Данило Шеган (danilo) wrote :

Landed on devel r8513, and should be available for testing on our translations.edge.launchpad.net server.

Changed in rosetta:
status: In Progress → Fix Committed
Revision history for this message
Dirk Stöcker (stoecker) wrote :

Works fine. Thanks. One issue thought: Sometimes there is suggestion state but no suggestion available. That is clearly a bug (which can now be solved, but probably should be fixed nevertheless).

Revision history for this message
Henning Eggers (henninge) wrote :

Can you provide an example URL, please?

Revision history for this message
Dirk Stöcker (stoecker) wrote :
Revision history for this message
Henning Eggers (henninge) wrote :

Created bug 383880 for it.

Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.