PO import fails with ForbiddenAttribute instead of failing with AssertionError

[Данило Шеган]

When we've got approved entry in the translation import queue which has no place to be imported into, instead of getting assertion error, we get a ForbiddenAttribute on entry_to_import.displayname().

First thing that I can think of is that it shouldn't be a method (it's a property), so it should be called without "()" at the end.

Tracebacks available on launchpad-error-list.

[Данило Шеган (danilo)]

Assertion was added by jtv (so assigning to him), and it doesn't seem serious enough if the queue continues running (though, it would be preferrable if the code didn't break like this).

[Данило Шеган (danilo)]

displayname is not defined in TranslationImportQueueEntry (neither interface nor database class).

[Jeroen T. Vermeulen (jtv)]

One of the drawbacks of dynamic languages... For the record, the bug is in lib/canonical/launchpad/scripts/po_import.py (line 71 in my version).

AFAICS we can just use entry_to_import.id in the error message, since it's for internal consumption only. A unique identification is more useful than a user-friendly one. So I suggest saying something like "Translation import queue entry with id %s is broken" (etc.)

[Данило Шеган (danilo)]

And adding a direct URL to edit the entry in question would be very helpful. Like https://translations.launchpad.net/+imports/555

[Jeroen T. Vermeulen (jtv)]

Fixed in RF 4855.