IPv6 flowlabel context update missing
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
rohc | Status tracked in Rohc-main | |||||
Rohc-1.7.x |
Won't Fix
|
Undecided
|
Didier Barvaux | |||
Rohc-2.0.x |
Fix Released
|
Medium
|
Didier Barvaux | |||
Rohc-main |
Fix Released
|
Medium
|
Didier Barvaux |
Bug Description
Didier,
the flowlabel from the IPv6 header is not updated into the context.
I propose the following patch:
diff --git a/src/decomp/
index 9ededdc..1c70639 100644
@@ -3297,6 +3299,8 @@ static void d_tcp_update_
{
memcpy(
memcpy(
+ ip_context-
+ ip_context-
}
}
tcp_context-
I found the bug as I used the attached https.pcap followed by your ipv6_tcp testcase.
Even the https has no IPv6 header, the memory of the flowlabel in the context
is not zero after running https test and a wrong flowlabel is taken from context
in the ipv6_tcp test.
https.pcap is from the WireEdit website to play with the tool.
Best,
Klaus Warnke
Klaus,
I'm very sorry, I completely missed your bug report.
The problem got detected by other means and fixed in 3dcc5bbeb66193a 67e08cc25e7f29d fcf2e6b84d.
Regards,
Didier