Incorrect format for UO-1-ID packet

[Didier Barvaux]

In c_generic.c, the UO-1-ID packet format is described as follow:

      0 1 2 3 4 5 6 7
    +-----+-----+-----+-----+-----+-----+-----+-----+
     | 1 0 |T=0 | IP-ID |
    +===+===+====+====+====+====+====+
     | M | SN | CRC |
    +-----+-----+-----+-----+-----+-----+-----+-----+

In the RFC 3095, section 5.7.3, page 81, the UO-1-ID packet format is described as follow:

      0 1 2 3 4 5 6 7
    +-----+-----+-----+-----+-----+-----+-----+-----+
     | 1 0 |T=0 | IP-ID |
    +===+===+====+====+====+====+====+
     | X | SN | CRC |
    +-----+-----+-----+-----+-----+-----+-----+-----+

The M bit should be a X bit.

Many thanks to Ahmed Fathy for reporting this problem in Question #121378 (https://answers.launchpad.net/rohc/+question/121378).

[Didier Barvaux (didier-barvaux)]

To be confirmed on 1.2.x.

[Didier Barvaux (didier-barvaux)]

To be confirmed on 1.3.x.

[Didier Barvaux (didier-barvaux)]

To be confirmed on main branch.

[Didier Barvaux (didier-barvaux)]

Confirmed on the 1.2.x branch.

[Didier Barvaux (didier-barvaux)]

Confirmed on the 1.3.x branch.

[Didier Barvaux (didier-barvaux)]

Confirmed on trunk.

[Didier Barvaux (didier-barvaux)]

The bug will not be fixed in the 1.3.x branch since it would break compatibility between 1.3.x releases. A note about the bug was added in the README file.
See http://bazaar.launchpad.net/~didier-barvaux/rohc/1.3.x/revision/172

[Didier Barvaux (didier-barvaux)]

The bug will not be fixed in the 1.2.x branch since it would break compatibility between 1.2.x releases. A note about the bug was added in the README file.

[Didier Barvaux (didier-barvaux)]

Update the compressor logic to replace the M bit by a X bit (always 0 at the moment). Also update the decompressor logic to read a X bit instead of the M bit (drop the packet if the X bit is set to 1 at the moment). See http://bazaar.launchpad.net/~didier-barvaux/rohc/main/revision/291

Extention support for UO-1-ID packets shall be written later. See bug #896842 entitled "Add extension support for UO-1-ID packet".

[Didier Barvaux (didier-barvaux)]

FAQ #1806 was updated to report the lack of extension support for UO-1-ID packets.