Library fails to build with GCC < 4.5

Bug #897831 reported by Didier Barvaux
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rohc
Status tracked in Rohc-main
1.2.x
Invalid
Undecided
Didier Barvaux
1.3.x
Invalid
Undecided
Didier Barvaux
Rohc-main
Fix Released
High
Didier Barvaux

Bug Description

Someone reported that the trunk fails to build on Debian because of the deprecated attributes that were added to several functions as part of revision #272. See http://bazaar.launchpad.net/~didier-barvaux/rohc/main/revision/272.

Tags: library build
Revision history for this message
Didier Barvaux (didier-barvaux) wrote :

Confirmed for GCC < 4.5 that does not accept any argument for the deprecated attribute.

Output is as below:
  CC rohc.lo
In file included from rohc.c:24:
rohc.h:523: error: wrong number of arguments specified for 'deprecated' attribute
rohc.h:528: error: wrong number of arguments specified for 'deprecated' attribute
rohc.h:533: error: wrong number of arguments specified for 'deprecated' attribute
rohc.h:538: error: wrong number of arguments specified for 'deprecated' attribute
rohc.h:543: error: wrong number of arguments specified for 'deprecated' attribute
rohc.h:560: error: wrong number of arguments specified for 'deprecated' attribute
rohc.h:565: error: wrong number of arguments specified for 'deprecated' attribute

I added builders to the ROHC buildbot to test build with several GCC flavours: 4.1.x, 4.3.x, 4.4.x, 4.5.x and 4.6.x. See the links below for the errors:
http://buildbot.rohc-lib.org:8011/builders/rohc-library-main-x86-gcc41/builds/3/steps/Build/logs/stdio
http://buildbot.rohc-lib.org:8011/builders/rohc-library-main-x86-gcc43/builds/3/steps/Build/logs/stdio
http://buildbot.rohc-lib.org:8011/builders/rohc-library-main-x86-gcc44/builds/3/steps/Build/logs/stdio

summary: - trunk fails to build on Debian
+ trunk fails to build with GCC < 4.5
summary: - trunk fails to build with GCC < 4.5
+ Library fails to build with GCC < 4.5
Revision history for this message
Didier Barvaux (didier-barvaux) wrote :

On trunk, remove the argument for the deprecated attributes since they are not supported by GCC < 4.5.
See http://bazaar.launchpad.net/~didier-barvaux/rohc/main/revision/294

Revision history for this message
Didier Barvaux (didier-barvaux) wrote :

Branch 1.2.x is not affected.

Revision history for this message
Didier Barvaux (didier-barvaux) wrote :

Branch 1.3.x is not affected.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.