IPv6 flowlabel context update missing

Bug #1511685 reported by Klaus Warnke on 2015-10-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rohc
Status tracked in Rohc-main
Rohc-1.7.x
Undecided
Didier Barvaux
Rohc-2.0.x
Medium
Didier Barvaux
Rohc-main
Medium
Didier Barvaux

Bug Description

Didier,

the flowlabel from the IPv6 header is not updated into the context.
I propose the following patch:

diff --git a/src/decomp/d_tcp.c b/src/decomp/d_tcp.c
index 9ededdc..1c70639 100644
@@ -3297,6 +3299,8 @@ static void d_tcp_update_ctxt(struct rohc_decomp_ctxt *const context,
   {
    memcpy(&ip_context->ctxt.v6.src_addr, ip_decoded->saddr, 16);
    memcpy(&ip_context->ctxt.v6.dest_addr, ip_decoded->daddr, 16);
+ ip_context->ctxt.v6.flow_label1 = ip_decoded->flowid >> 16;
+ ip_context->ctxt.v6.flow_label2 = ip_decoded->flowid & 0xffff;
   }
  }
  tcp_context->ip_contexts_nr = decoded->ip_nr;

I found the bug as I used the attached https.pcap followed by your ipv6_tcp testcase.
Even the https has no IPv6 header, the memory of the flowlabel in the context
is not zero after running https test and a wrong flowlabel is taken from context
in the ipv6_tcp test.

https.pcap is from the WireEdit website to play with the tool.

Best,
Klaus Warnke

Klaus Warnke (k-warnke) wrote :
Didier Barvaux (didier-barvaux) wrote :

Klaus,

I'm very sorry, I completely missed your bug report.

The problem got detected by other means and fixed in 3dcc5bbeb66193a67e08cc25e7f29dfcf2e6b84d.

Regards,
Didier

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments