support origin=any distroseries=natty in the review-stats call

Bug #757695 reported by Michael Vogt
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ratings and Reviews server
Fix Released
Michael Nelson

Bug Description

Currntly the review-stats call lets me filter by origin and distroseries.

But I can't call "origin=any", "distroseries=natty". Only origin=specific-origin and distroseries=speficic-series

This means that the client will have to make a API call for each availalbe commercial-ppa that is available via
software-center-agent to get the stats for the for-pay app. Currently we have ~15 or so in maverick and naty
will probably have even more soon. Would be nice to have just one API call to get all the stats for e.g. natty.


Tags: kb-task sp-1

Related branches

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Adding support to return stats across origins is trivial, but two related points:

1) We could return stats for the same package from different origins,
2) the resulting json does not (currently) contain any info to let you know which stat is for which origin (or distroseries, for that matter)

Is that OK, or do we also need to add origin or distroseries when origin or distroseries (respectively) is 'any' (or just include them always?)

Revision history for this message
Michael Vogt (mvo) wrote :

I think thats ok for natty because we do not have many origins, just, and the for-pay PPAs. There should be no overlap there in the packagename (as this will cause other problems too).

But once we expand it into PPAs we need either to include the origins information in the stat json or aggregate on the fly. But my gut feeling is that when we open this up for all PPAs we need to incldue something like a fake origin "default-system" or somesuch that will include "ubuntu,canoncial,all-for-pay-ppas". And make additional calls for each enabled PPAs. This way we get away with just one call to the API for most users.

tags: added: kb-task sp-1
Changed in rnr-server:
assignee: nobody → Michael Nelson (michael.nelson)
importance: Undecided → Low
Changed in rnr-server:
status: New → Fix Committed
Changed in rnr-server:
milestone: none → 11.05
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.