post report/abuse should be https
Bug #691002 reported by
Michael Vogt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ratings and Reviews server |
Fix Released
|
Low
|
Anthony Lenton |
Bug Description
Because we use OAuth PLAINTEXT as the signature we need to submit reviews via https, otherwise people
may obtain the SSO token secrets from our requests via sniffing the wire/wlan trafic.
Related branches
lp:~elachuni/piston-mini-client/dual-scheme-support
- Danny Tamez (community): Approve
- software-store-developers: Pending requested
-
Diff: 424 lines (+178/-23)8 files modifieddoc/conf.py (+2/-0)
doc/index.rst (+1/-0)
doc/quickstart.rst (+35/-0)
doc/reference.rst (+33/-0)
piston_mini_client/__init__.py (+33/-12)
piston_mini_client/failhandlers.py (+24/-1)
piston_mini_client/serializers.py (+6/-0)
piston_mini_client/test/test_resource.py (+44/-10)
lp:~elachuni/rnr-server/rnrclient-schemes
- Danny Tamez (community): Approve
-
Diff: 183 lines (+57/-28)2 files modifiedrnrclient.py (+12/-6)
tests/test_rnrclient.py (+45/-22)
tags: | added: kb-task |
Changed in rnr-server: | |
assignee: | nobody → Anthony Lenton (elachuni) |
status: | Confirmed → In Progress |
Changed in rnr-server: | |
status: | In Progress → Fix Committed |
Changed in rnr-server: | |
milestone: | none → 11.05 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think this is both of a client-side issue and a deployment issue, but so far our code base doesn't depend on being served over http or https.
The client library should allow you to call certain methods over http but others over https. That is something piston-mini-client is missing, and then rnrclient. I've created bug #704885 for this.
One thing the server *could* do is check that each method is being served over http(s) as intended, and fail otherwise. We could provide two decorators (ensure_http and ensure_https) and apply them to each piston resource as needed.
I'd recommend a setting to disable these checks, so that the code can still be deployed on a server that doesn't respond to both schemes.