Can't edit reviews
Bug #1318144 reported by
Michał Sawicz
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ratings and Reviews server |
Fix Released
|
High
|
Fabián Ezequiel Gallina | ||
ubuntuone-credentials (Ubuntu) |
Fix Released
|
High
|
Paweł Stołowski | ||
unity-scope-click (Ubuntu) |
Fix Released
|
High
|
Paweł Stołowski | ||
Vivid |
Fix Released
|
Undecided
|
Unassigned | ||
unity8 (Ubuntu) |
Fix Released
|
High
|
Albert Astals Cid | ||
Vivid |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
It seems impossible to edit reviews at the moment. I get the review entry even though I reviewed already and I'm allowed to send another review, which actually gets lost somewhere.
I imagine we want to limit the number of reviews to 1 per U1 account, but it should be possible to send a new/modified one. Maybe the review entry should be pre-filled with the previous review so it's obvious you can edit?
Related branches
lp:~fgallina/rnr-server/edit-click-review-handler
- Natalia Bidart (community): Approve
-
Diff: 343 lines (+173/-15)7 files modifiedsrc/clickreviews/api/handlers.py (+17/-1)
src/clickreviews/api/urls.py (+3/-0)
src/clickreviews/forms.py (+22/-0)
src/clickreviews/models.py (+8/-2)
src/clickreviews/tests/test_forms.py (+60/-0)
src/clickreviews/tests/test_handlers.py (+45/-12)
src/clickreviews/tests/test_models.py (+18/-0)
lp:~fgallina/rnr-server/delete-click-review-handler
- Matias Bordese (community): Approve
-
Diff: 119 lines (+69/-1)4 files modifiedsrc/clickreviews/api/handlers.py (+8/-1)
src/clickreviews/models.py (+7/-0)
src/clickreviews/tests/test_handlers.py (+38/-0)
src/clickreviews/tests/test_models.py (+16/-0)
lp:~fgallina/rnr-server/exclude-deleted-hidden-click-reviews
- Matias Bordese (community): Approve
-
Diff: 117 lines (+48/-7)4 files modifiedsrc/clickreviews/api/handlers.py (+4/-5)
src/clickreviews/models.py (+11/-2)
src/clickreviews/tests/test_handlers.py (+11/-0)
src/clickreviews/tests/test_models.py (+22/-0)
lp:~stolowski/ubuntuone-credentials/get-consumer-key
- dobey (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 97 lines (+34/-1)6 files modifiedCMakeLists.txt (+1/-1)
debian/changelog (+6/-0)
debian/libubuntuoneauth-2.0-0.symbols (+1/-0)
libubuntuoneauth/tests/test_token.cpp (+14/-0)
libubuntuoneauth/token.cpp (+10/-0)
libubuntuoneauth/token.h (+2/-0)
lp:~aacid/unity8/edit_reviews
- Andrea Cimitan (community): Approve
- Paweł Stołowski (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 352 lines (+246/-46)7 files modifiedqml/Dash/Previews/PreviewRatingDisplay.qml (+11/-46)
qml/Dash/Previews/PreviewRatingEdit.qml (+80/-0)
qml/Dash/Previews/PreviewRatingInput.qml (+3/-0)
qml/Dash/Previews/PreviewRatingSingleDisplay.qml (+70/-0)
qml/Dash/Previews/PreviewWidgetFactory.qml (+1/-0)
tests/qmltests/CMakeLists.txt (+1/-0)
tests/qmltests/Dash/Previews/tst_PreviewRatingEdit.qml (+80/-0)
lp:~stolowski/unity-scope-click/edit-reviews
- dobey (community): Approve
- Alejandro J. Cura (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 447 lines (+260/-20)8 files modifiedCMakeLists.txt (+1/-1)
debian/control (+1/-1)
libclickscope/click/preview.cpp (+81/-15)
libclickscope/click/preview.h (+1/-0)
libclickscope/click/reviews.cpp (+52/-0)
libclickscope/click/reviews.h (+5/-2)
libclickscope/tests/test_reviews.cpp (+117/-0)
scope/clickapps/apps-scope.cpp (+2/-1)
lp:~stolowski/unity-scope-click/edit-reviews-15-04
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Alejandro J. Cura (community): Approve
-
Diff: 455 lines (+261/-20)8 files modifiedCMakeLists.txt (+1/-1)
debian/control (+1/-1)
libclickscope/click/preview.cpp (+82/-15)
libclickscope/click/preview.h (+1/-0)
libclickscope/click/reviews.cpp (+52/-0)
libclickscope/click/reviews.h (+5/-2)
libclickscope/tests/test_reviews.cpp (+117/-0)
scope/clickapps/apps-scope.cpp (+2/-1)
Superseded
for merging
into
lp:unity-scope-click
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Unity Team: Pending requested
-
Diff: 374 lines (+187/-20)8 files modifiedCMakeLists.txt (+1/-1)
debian/control (+1/-1)
libclickscope/click/preview.cpp (+82/-15)
libclickscope/click/preview.h (+1/-0)
libclickscope/click/reviews.cpp (+52/-0)
libclickscope/click/reviews.h (+5/-2)
libclickscope/tests/test_reviews.cpp (+43/-0)
scope/clickapps/apps-scope.cpp (+2/-1)
lp:~stolowski/ubuntuone-credentials/get-consumer-key-15-04
- PS Jenkins bot: Approve (continuous-integration)
- dobey (community): Approve
-
Diff: 97 lines (+34/-1)6 files modifiedCMakeLists.txt (+1/-1)
debian/changelog (+6/-0)
debian/libubuntuoneauth-2.0-0.symbols (+1/-0)
libubuntuoneauth/tests/test_token.cpp (+14/-0)
libubuntuoneauth/token.cpp (+10/-0)
libubuntuoneauth/token.h (+2/-0)
affects: | software-center-agent → rnr-server |
Changed in rnr-server: | |
assignee: | nobody → Fabián Ezequiel Gallina (fgallina) |
no longer affects: | ubuntu-ux |
Changed in unity-scope-click (Ubuntu): | |
importance: | Undecided → Medium |
Changed in rnr-server: | |
status: | Triaged → Fix Committed |
Changed in rnr-server: | |
status: | Fix Committed → Fix Released |
Changed in unity-scope-click (Ubuntu): | |
assignee: | nobody → Pawel Stolowski (stolowski) |
Changed in unity-scope-click (Ubuntu): | |
importance: | Medium → High |
Changed in unity8 (Ubuntu): | |
importance: | Undecided → High |
Changed in unity-scope-click (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in unity8 (Ubuntu): | |
assignee: | nobody → Albert Astals Cid (aacid) |
Changed in unity8 (Ubuntu): | |
status: | New → In Progress |
Changed in ubuntuone-credentials (Ubuntu): | |
status: | New → Confirmed |
Changed in ubuntuone-credentials (Ubuntu): | |
assignee: | nobody → Pawel Stolowski (stolowski) |
status: | Confirmed → In Progress |
importance: | Undecided → High |
Changed in ubuntuone-credentials (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in unity-scope-click (Ubuntu Vivid): | |
status: | New → Fix Released |
Changed in unity8 (Ubuntu Vivid): | |
status: | New → Fix Released |
To post a comment you must log in.
The reviews server doesn't (didn't last time I checked [1]) allow a second review for the same user, returning a 400 not allowed [2].
The other aspect is exactly right - the click reviews server only allows creating reviews right now. It's trivial to move the other functionality across from the older deb-reviews app, but we'd like to do that as it's needed. So checking what's there, I assume the things we'll want right now are:
* edit review (PUT to the review resource)
* delete review (DELETE to the review resource, but doesn't delete from the db, just filters out)
Things that we may need soon (and which are easy enough to do at the same time on the server):
* flag a review
* mark a review as useful
* include review 'usefulness' on the review resource uri
* Add a hal+json format for appropriate accept header (for consistency with other apis)
[1] See the example at the bottom returning a 400 with the error "A user cannot create multiple reviews for an app." https:/ /wiki.ubuntu. com/AppStore/ Interfaces/ RatingsAndRevie ws