Can't edit reviews

[Michał Sawicz]

It seems impossible to edit reviews at the moment. I get the review entry even though I reviewed already and I'm allowed to send another review, which actually gets lost somewhere.

I imagine we want to limit the number of reviews to 1 per U1 account, but it should be possible to send a new/modified one. Maybe the review entry should be pre-filled with the previous review so it's obvious you can edit?

[Michael Nelson (michael.nelson)]

The reviews server doesn't (didn't last time I checked [1]) allow a second review for the same user, returning a 400 not allowed [2].

The other aspect is exactly right - the click reviews server only allows creating reviews right now. It's trivial to move the other functionality across from the older deb-reviews app, but we'd like to do that as it's needed. So checking what's there, I assume the things we'll want right now are:
 * edit review (PUT to the review resource)
 * delete review (DELETE to the review resource, but doesn't delete from the db, just filters out)

Things that we may need soon (and which are easy enough to do at the same time on the server):
 * flag a review
 * mark a review as useful
 * include review 'usefulness' on the review resource uri
 * Add a hal+json format for appropriate accept header (for consistency with other apis)

[1] See the example at the bottom returning a 400 with the error "A user cannot create multiple reviews for an app." https://wiki.ubuntu.com/AppStore/Interfaces/RatingsAndReviews

[Alejandro J. Cura (alecu)]

Here are the relevant bits in the spec: https://wiki.ubuntu.com/AppStore/Interfaces/RatingsAndReviews#Editing_a_review

[Leo Arias (elopio)]

Alecu, I think this story needs an user acceptance test:

Install a click package [1]
Open the store scope
Search for the installed app.
Open the preview.
Select 3 stars.
Write a review: "test review"
Click send.
Select 4 stars.
Edit the review: "test review edited"
Click send.
Assert that the review was edited.

I think the other details of the story can be tested with lower level tests.
Let us know if you need a hand getting started with the high level test.

[1] This can be done behind the UI, like in https://bazaar.launchpad.net/~canonical-platform-qa/ubuntu-sanity-tests/trunk/view/head:/ubuntu_sanity_tests/helpers/click.py#L31

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Launchpad Janitor (janitor)]

This bug was fixed in the package unity8 - 8.02+15.10.20150518.1-0ubuntu1

---------------
unity8 (8.02+15.10.20150518.1-0ubuntu1) wily; urgency=medium

  [ Albert Astals Cid ]
  * Add overrides to override functions
  * Implement "rating-edit" preview widget (LP: #1318144)
  * Make the DashContent::test_mainNavigation test more stable (LP:
    #1450809)
  * Use art height as implicitHeight when the header is overlayed and
    there's no summary

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Daniel d'Andrada ]
  * Introducing FloatingFlickable
  * Make Ubuntu.Gestures components install TouchRegistry by themselves

  [ Michael Terry ]
  * Fix a possible crash in our PAM threading code. (LP: #1425362) (LP:
    #1425362)
  * Fix the lockscreen becoming unresponsive after testing an app on the
    device from QtCreator. (LP: #1435364)

  [ Nick Dedekind ]
  * Fixed desktop stage app focus.
  * Fixed issue in laggy indicator autpilot tests (LP: #1446846)

 -- CI Train Bot <email address hidden> Mon, 18 May 2015 23:04:39 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package unity-scope-click - 0.1.1+15.10.20150617-0ubuntu1

---------------
unity-scope-click (0.1.1+15.10.20150617-0ubuntu1) wily; urgency=medium

  [ Alejandro J. Cura ]
  * Show the "Refund" button and call the pay-service when clicked

  [ CI Train Bot ]
  * New rebuild forced.

  [ Michael Terry ]
  * Add a missing iostream include.

  [ Pawel Stolowski ]
  * Support for review editing. (LP: #1318144)

  [ Rodney Dawes ]
  * Finish remaining integration of refunds support in click scope.
  * Remove the g++-4.9 explicit dependency to prepare for gcc5
    migration. (LP: #1452343)

 -- CI Train Bot <email address hidden> Wed, 17 Jun 2015 16:59:27 +0000