Server won't accept reviews for apps with distroseries="click"
Bug #1262627 reported by
Michael Nelson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ratings and Reviews server |
Fix Released
|
High
|
Michael Nelson |
Bug Description
Currently the rnr server when it receives a review, it checks to see if it already has any reviews for the given package name in the given repository, by checking via the Launchpad api for the package existence.
For a click package, launchpad won't know anything about the package (or the ubuntu click repository), and so returns a bad request (as the package doesn't exist).
We need to update the verify_
Related branches
lp:~michael.nelson/rnr-server/1262627-verify-click
- James Tait (community): Approve
- Michael Nelson (community): Approve
-
Diff: 246 lines (+99/-17)6 files modifiedsrc/reviewsapp/forms.py (+2/-2)
src/reviewsapp/schema.py (+4/-0)
src/reviewsapp/tests/test_handlers.py (+1/-1)
src/reviewsapp/tests/test_rnrclient.py (+3/-3)
src/reviewsapp/tests/test_utilities.py (+73/-9)
src/reviewsapp/utilities.py (+16/-2)
Changed in rnr-server: | |
assignee: | nobody → Michael Nelson (michael.nelson) |
status: | Triaged → In Progress |
Changed in rnr-server: | |
status: | In Progress → Fix Committed |
Changed in rnr-server: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.