Crash in fire marble game in 0.9.8

[Petter Uvesten]

Mistakenly put a fire marble on top of another (blue on yellow, I think) in the fire marble game. Got the beach ball for a couple of seconds, then crash. Logs attached.

(Btw, thanks for resurrecting Riven! It's the first time I've played since '98 ;)

Info:
MBP 17" 2011
8GB
AMD Radeon HD 6750M 1024 MB graphics
10.7.1
10th Anniversary DVD edition

[Jean-Francois Roy (jeanfrancois.roy)]

Can you try again once 0.9.9 is out? I have lost the symbols for 0.9.8 unfortunately.

[Jean-Francois Roy (jeanfrancois.roy)]

Also, if you can reproduce the crash, attach a save game just before the issue with the steps required to make the crash occur.

[Petter Uvesten (uvesten)]

Saw this just now, have been traveling without access to the internet
for a while.

Do you still want me to reproduce the bug using 0.9.9?

On Wed, Dec 28, 2011 at 6:03 PM, Jean-Francois Roy <email address hidden> wrote:
> Also, if you can reproduce the crash, attach a save game just before the
> issue with the steps required to make the crash occur.
>
> ** Changed in: rivenx
>   Importance: Undecided => High
>
> ** Changed in: rivenx
>       Status: New => Triaged
>
> ** Changed in: rivenx
>     Assignee: (unassigned) => Jean-Francois Roy (jeanfrancois.roy)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/864002
>
> Title:
>  Crash in fire marble game in 0.9.8
>
> Status in Riven X:
>  Triaged
>
> Bug description:
>  Mistakenly put a fire marble on top of another (blue on yellow, I
>  think) in the fire marble game. Got the beach ball for a couple of
>  seconds, then crash. Logs attached.
>
>  (Btw, thanks for resurrecting Riven! It's the first time I've played
>  since '98 ;)
>
>  Info:
>  MBP 17" 2011
>  8GB
>  AMD Radeon HD 6750M 1024 MB graphics
>  10.7.1
>  10th Anniversary DVD edition
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/rivenx/+bug/864002/+subscriptions

[John Macuk (jwmacuk)]

Any ETA for 0.9.9?

[Paul Ev (pe-linked)]

Not sure if this is still being actively maintained (I hope so!) but I ran into the same bug, and I had a look at the code in the debugger. Didn't want to do a fork and pull request yet, so here's a patch for this one:

diff --git a/Engine/RXScriptEngine.m b/Engine/RXScriptEngine.m
index 0a82e26..5a94377 100644
--- a/Engine/RXScriptEngine.m
+++ b/Engine/RXScriptEngine.m
@@ -4067,7 +4067,7 @@ DEFINE_COMMAND(xtakeit)

   // update the marble's position by moving its hotspot
   RXHotspot* hotspot = (RXHotspot*)NSMapGet([_card hotspotsNameMap], marble_var);
- if (new_marble_pos == UINT32_MAX) {
+ if (new_marble_pos == UINT32_MAX || new_marble_pos == 0) {
     // the marble was dropped somewhere outside the grid;
     // set the marble variable to 0 to indicate the marble is in its receptacle
     [gs setUnsigned32:0 forKey:marble_var];

A one-liner, obviously, but I can also do a fork on GitHub, if that's more convenient. Just let me know.