Improper matching/validation of mount-control
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
review-tools |
New
|
Undecided
|
Unassigned |
Bug Description
The snap has this:
mntctl:
interface: mount-control
mount:
- what: /dev/sd*
where: /mnt/*
type:
- vfat
options:
- rw
- sync
- async
persistent: false
The snap declaration json has this:
{
"mount-control": {
"allow-
"on-store": [
],
"
"mount": [
{
"rw",
],
"type": [
],
"what": "/dev/sd\\*",
}
]
}
},
"allow-
"on-store": [
],
"
"mount": [
{
"rw",
],
"type": [
],
"what": "/dev/sd\\*",
}
]
}
}
}
}
I think these should match, but review-tools says:
- declaration-
human review required due to 'allow-
Please let me know via direct message if you need more specifics, I can point you to the concrete snap that is having this issue.
- Daniel
Related branches
- Emilia Torino: Approve
- Samuele Pedroni: Pending requested
-
Diff: 196 lines (+159/-1)2 files modifiedreviewtools/sr_declaration.py (+31/-1)
reviewtools/tests/test_sr_declaration.py (+128/-0)
I have proposed a fix for this in review-tools but the current proposal means your declaration would have to change to be the following:
"mount- control" : {
"allow- installation" : [
"plug- attributes" : {
"mount" : [
{
"where" : "/mnt/\\*",
"what" : "/dev/sd\\*",
"type" : "vfat",
"persistent" : "false",
"options" : "(rw|a?sync)"
}
"on-store" : [
" honeywell- international- inc"
"allow- auto-connection ": {
"plug- attributes" : {
"mount" : [
"where" : "/mnt/\\*",
"what" : "/dev/sd\\*",
"type" : "vfat",
"persistent ": "false",
"options" : "(rw|a?sync)"
"on- store": [
"honeywell- international- inc"
{
]
},
]
}
],
{
}
]
},
]
}
},