review-tools error message about external symlinks should show the targets
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
review-tools |
Fix Released
|
Undecided
|
Alex Murray |
Bug Description
It would be helpful to know not just that there are external symlinks pointing to outside of the snap but also where they are pointing to be able to fix it. For example with absolute symlinks where they should be fixed to just be relative, it would be helpful if review-tools also output the specific target of those symlinks. This is the current output for example:
```
- lint-snap-
package contains external symlinks: usr/lib/
```
All of these files are absolute symlinks pointing to the versioned .so file, so it would be easy for folks to see that these just need to become relative in the same directory to fix the problem.
```
$ readlink ./usr/lib/
/lib/aarch64-
$ readlink ./usr/lib/
/lib/aarch64-
$ readlink ./usr/lib/
/lib/aarch64-
$ readlink ./usr/lib/
/lib/aarch64-
```
Related branches
- Emilia Torino: Approve
-
Diff: 66 lines (+6/-6)3 files modifiedreviewtools/common.py (+1/-1)
reviewtools/tests/test_sr_lint.py (+2/-2)
tests/test.sh.expected (+3/-3)
Changed in review-tools: | |
status: | New → Fix Released |
assignee: | nobody → Alex Murray (alexmurray) |