New Snapcraft 5.0 top-level metadata triggers manual review

[John Neffenger]

Adding the new Snapcraft 5.0 top-level metadata to the OpenJFX snap package triggered a manual review. The automatic review and upload failed with the warning:

  unknown entries in snap.yaml: 'links' lint-snap-v2_unknown_field

The revision that failed the automatic review is found at the link below:

  OpenJFX Version 17+17 Revision 46
  https://dashboard.snapcraft.io/snaps/openjfx/revisions/46/

To build this revision, I added the new metadata to the file 'snap/snapcraft.yaml' as follows:

  contact: https://github.com/jgneff/openjfx/discussions
  donation: https://github.com/sponsors/jgneff
  issues: https://github.com/jgneff/openjfx/issues
  source-code: https://github.com/jgneff/openjfx.git
  website: https://www.status6.com

After building the snap, the links were added to the file 'meta/snap.yaml' in the resulting package as shown below:

  links:
    contact:
    - https://github.com/jgneff/openjfx/discussions
    donation:
    - https://github.com/sponsors/jgneff
    issues:
    - https://github.com/jgneff/openjfx/issues
    source-code:
    - https://github.com/jgneff/openjfx.git
    website:
    - https://www.status6.com

I rejected the manual review and built the Snap package again without the new metadata, and then the automatic review and upload was successful with revision 47, shown below:

  OpenJFX Version 17+17 Revision 47
  https://dashboard.snapcraft.io/snaps/openjfx/revisions/47/

[Sergio Schvezov (sergiusens)]

This is correct, the feature is still missing store side support, which is being implemented now.

[Logic Over Snacks (logicoversnacks)]

I've added a pull request that adds a more complete list of optional fields since I got caught by this bug when using the 'compression' field.
https://code.launchpad.net/~logicoversnacks/review-tools/+git/review-tools/+merge/429123

[Alex Murray (alexmurray)]

compression is a field that snapcraft understands but snapd does not as far as I know - and hence I don't think it should be present in a snap.yaml - snapcraft should remove this when transforming the snapcraft.yaml into the snap.yaml - as such I don't think review-tools should support it either.

[Logic Over Snacks (logicoversnacks)]

I see, my apologies, in that case this would be a bug in electron-builder instead then ^^