| 2019-09-18 13:27:01 |
Jamie Strandboge |
bug |
|
|
added bug |
| 2019-09-18 13:27:10 |
Jamie Strandboge |
review-tools: status |
New |
In Progress |
|
| 2019-09-18 13:27:21 |
Jamie Strandboge |
review-tools: importance |
Undecided |
Critical |
|
| 2019-09-18 13:27:31 |
Jamie Strandboge |
review-tools: importance |
Critical |
High |
|
| 2019-09-18 13:27:34 |
Jamie Strandboge |
review-tools: assignee |
|
Jamie Strandboge (jdstrand) |
|
| 2019-09-18 20:52:56 |
Jamie Strandboge |
description |
https://github.com/snapcore/snapd/pull/6767 adds the new icon set feature to snapd. During the review, it was discovered that neither the review-tools nor snapd were validating the input of desktop files using Icon= entries in general (outside of the new feature). Various checks were added to the review-tools with the intention of matching snapd's checks and flag when an Icon check would fail in snapd. While various unit and functional tests were added to the review-tools, the checks (and also the accompanying tests) for requiring .svg and .png extensions were too strict (ie, they did not match the new snapd checks) and should've only been applied to files in meta/gui/icons and not files in $SNAP. This had the unintentional effect of blocking valid icon extensions, such as .ico.
A fix in progress. While the fix to the review-tools is not yet in production, snap developers can either request a manual review for snap revisions that now incorrectly fail automated review and so someone can manually approve the revision (or change to use png or svg instead, but the update should be in production soon). |
https://github.com/snapcore/snapd/pull/6767 adds the new icon set feature to snapd. During the review, it was discovered that neither the review-tools nor snapd were validating the input of desktop files using Icon= entries in general (outside of the new feature). Various checks were added to the review-tools with the intention of matching snapd's checks and flag when an Icon check would fail in snapd. While various unit and functional tests were added to the review-tools, the checks (and also the accompanying tests) for requiring .svg and .png extensions were too strict (ie, they did not match the new snapd checks) and should've only been applied to files in meta/gui/icons and not files in $SNAP. This had the unintentional effect of blocking valid icon extensions, such as .ico.
A fix in progress. While the fix to the review-tools is not yet in production, snap developers can either request a manual review for snap revisions that now incorrectly fail automated review and so someone can manually approve the revision or change to use png or svg instead (but the update should be in production soon). |
|
| 2019-09-22 21:46:40 |
dev |
review-tools: assignee |
Jamie Strandboge (jdstrand) |
dev (ionomy) |
|
| 2019-09-22 21:47:24 |
dev |
summary |
new icon file check too restrictive for files in $SNAP |
new icon file check too restrictive for files in $SNAP (untested) |
|
| 2019-09-22 21:50:08 |
dev |
description |
https://github.com/snapcore/snapd/pull/6767 adds the new icon set feature to snapd. During the review, it was discovered that neither the review-tools nor snapd were validating the input of desktop files using Icon= entries in general (outside of the new feature). Various checks were added to the review-tools with the intention of matching snapd's checks and flag when an Icon check would fail in snapd. While various unit and functional tests were added to the review-tools, the checks (and also the accompanying tests) for requiring .svg and .png extensions were too strict (ie, they did not match the new snapd checks) and should've only been applied to files in meta/gui/icons and not files in $SNAP. This had the unintentional effect of blocking valid icon extensions, such as .ico.
A fix in progress. While the fix to the review-tools is not yet in production, snap developers can either request a manual review for snap revisions that now incorrectly fail automated review and so someone can manually approve the revision or change to use png or svg instead (but the update should be in production soon). |
https://github.com/snapcore/snapd/pull/6767 adds the new icon set feature to snapd. During the review, it was discovered that neither the review-tools nor snapd were validating the input of desktop files using Icon= entries in general (outside of the new feature). Various checks were added to the review-tools with the intention of matching snapd's checks and flag when an Icon check would fail in snapd. While various unit and functional tests were added to the review-tools, the checks (and also the accompanying tests) for requiring .svg and .png extensions were too strict (ie, they did not match the new snapd checks) and should've only been applied to files in meta/gui/icons and not files in $SNAP. This had the unintentional effect of blocking valid icon extensions, such as .ico.
A fix in progress. While the fix to the review-tools is not yet in production, snap developers can either request a manual review for snap revisions that now incorrectly fail automated review and so someone can manually approve the revision or change to use png or svg instead (but the update should be in production soon).
This bug caused many snaps to break, canonical employee John R. Lenton banned user reporting this bug and abused his position on canonical which ended up in him being caught lying. |
|
| 2019-09-22 21:54:28 |
dev |
description |
https://github.com/snapcore/snapd/pull/6767 adds the new icon set feature to snapd. During the review, it was discovered that neither the review-tools nor snapd were validating the input of desktop files using Icon= entries in general (outside of the new feature). Various checks were added to the review-tools with the intention of matching snapd's checks and flag when an Icon check would fail in snapd. While various unit and functional tests were added to the review-tools, the checks (and also the accompanying tests) for requiring .svg and .png extensions were too strict (ie, they did not match the new snapd checks) and should've only been applied to files in meta/gui/icons and not files in $SNAP. This had the unintentional effect of blocking valid icon extensions, such as .ico.
A fix in progress. While the fix to the review-tools is not yet in production, snap developers can either request a manual review for snap revisions that now incorrectly fail automated review and so someone can manually approve the revision or change to use png or svg instead (but the update should be in production soon).
This bug caused many snaps to break, canonical employee John R. Lenton banned user reporting this bug and abused his position on canonical which ended up in him being caught lying. |
https://github.com/snapcore/snapd/pull/6767 adds the new icon set feature to snapd. During the review, it was discovered that neither the review-tools nor snapd were validating the input of desktop files using Icon= entries in general (outside of the new feature). Various checks were added to the review-tools with the intention of matching snapd's checks and flag when an Icon check would fail in snapd. While various unit and functional tests were added to the review-tools, the checks (and also the accompanying tests) for requiring .svg and .png extensions were too strict (ie, they did not match the new snapd checks) and should've only been applied to files in meta/gui/icons and not files in $SNAP. This had the unintentional effect of blocking valid icon extensions, such as .ico.
~~A fix in progress~~ A fix was promised several times on several points by devs, turned out they lied and nothing was fixed until now and it is still open.
While the fix to the review-tools is yet even not in development, change to use png or svg instead (but the update should be in production soon).
This bug caused many snaps to break, canonical employee John R. Lenton banned user reporting this bug and abused his position on canonical which ended up in him being caught lying. |
|
| 2019-09-22 22:00:48 |
dev |
bug |
|
|
added subscriber Katherine Ollerhead |
| 2019-09-22 22:01:04 |
dev |
bug |
|
|
added subscriber Sierra Fredenrich |
| 2019-09-22 22:01:36 |
dev |
review-tools: status |
In Progress |
Incomplete |
|
| 2019-09-23 09:05:33 |
Colin Watson |
description |
https://github.com/snapcore/snapd/pull/6767 adds the new icon set feature to snapd. During the review, it was discovered that neither the review-tools nor snapd were validating the input of desktop files using Icon= entries in general (outside of the new feature). Various checks were added to the review-tools with the intention of matching snapd's checks and flag when an Icon check would fail in snapd. While various unit and functional tests were added to the review-tools, the checks (and also the accompanying tests) for requiring .svg and .png extensions were too strict (ie, they did not match the new snapd checks) and should've only been applied to files in meta/gui/icons and not files in $SNAP. This had the unintentional effect of blocking valid icon extensions, such as .ico.
~~A fix in progress~~ A fix was promised several times on several points by devs, turned out they lied and nothing was fixed until now and it is still open.
While the fix to the review-tools is yet even not in development, change to use png or svg instead (but the update should be in production soon).
This bug caused many snaps to break, canonical employee John R. Lenton banned user reporting this bug and abused his position on canonical which ended up in him being caught lying. |
https://github.com/snapcore/snapd/pull/6767 adds the new icon set feature to snapd. During the review, it was discovered that neither the review-tools nor snapd were validating the input of desktop files using Icon= entries in general (outside of the new feature). Various checks were added to the review-tools with the intention of matching snapd's checks and flag when an Icon check would fail in snapd. While various unit and functional tests were added to the review-tools, the checks (and also the accompanying tests) for requiring .svg and .png extensions were too strict (ie, they did not match the new snapd checks) and should've only been applied to files in meta/gui/icons and not files in $SNAP. This had the unintentional effect of blocking valid icon extensions, such as .ico.
A fix in progress. While the fix to the review-tools is not yet in production, snap developers can either request a manual review for snap revisions that now incorrectly fail automated review and so someone can manually approve the revision (or change to use png or svg instead, but the update should be in production soon). |
|
| 2019-09-23 09:06:46 |
Colin Watson |
summary |
new icon file check too restrictive for files in $SNAP (untested) |
new icon file check too restrictive for files in $SNAP |
|
| 2019-09-23 09:17:55 |
Martin Wimpress |
review-tools: assignee |
dev (ionomy) |
Jamie Strandboge (jdstrand) |
|
| 2019-09-23 09:54:49 |
Katherine Ollerhead |
removed subscriber Katherine Ollerhead |
|
|
|
| 2019-09-23 11:50:06 |
Oliver Grawert |
review-tools: status |
Incomplete |
In Progress |
|
| 2019-09-25 14:24:59 |
Jamie Strandboge |
review-tools: status |
In Progress |
Fix Released |
|
