Locking seems wrong in base_report_to_printer's update()
Bug #1308635 reported by
Lionel Sausin - Initiatives/Numérigraphe
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Report - Printing and Sending |
New
|
Undecided
|
Numérigraphe | ||
Bug Description
Please forgive me if I'm wrong, but the locking in printing.
If I'm not mistaken, that does not protect us from concurrent changes anyway :
- if what we read is immutable than the value is copied and locking is unnecessary
- if it's mutable then we're getting a "reference" to the shared object, and should keep the lock until we're completely done with it
From my quick code survey, the variables seem to contain a boolean and a float so I guess no locking is needed.
Related branches
lp:~numerigraphe-team/report-print-send/7.0-no-lock-in-update-1308635-ls
- Yannick Vaucher @ Camptocamp: Needs Resubmitting (moved on github)
- Loïc Bellier - Numérigraphe (community): Abstain
-
Diff: 32 lines (+6/-11)1 file modifiedbase_report_to_printer/printing.py (+6/-11)
| Changed in report-print-send: | |
| assignee: | nobody → Numérigraphe (numerigraphe-team) |
To post a comment you must log in.
