Reno does not choose correct earliest version when old stable branches are closed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
reno |
Fix Released
|
High
|
Doug Hellmann |
Bug Description
Ironic's first mitaka release was 4.3.0, however, reno picks it up as 5.1.0.
$ cd ironic
$ git checkout 180234b445f7127
$ reno -v report --branch stable/mitaka
scanning ./releasenotes/
looking for ref 'stable/mitaka' as 'refs/heads/
looking for ref 'stable/mitaka' as 'refs/remotes/
looking for ref 'stable/mitaka' as 'refs/tags/
looking for ref 'stable/mitaka' as 'refs/tags/
found ref 'stable/mitaka' as 'refs/tags/
current repository version: 5.1.3
looking for ref 'stable/mitaka' as 'refs/heads/
looking for ref 'stable/mitaka' as 'refs/remotes/
looking for ref 'stable/mitaka' as 'refs/tags/
looking for ref 'stable/mitaka' as 'refs/tags/
found ref 'stable/mitaka' as 'refs/tags/
versions by date [u'5.1.3', u'5.1.2', u'5.1.1', u'5.1.0', u'5.0.0', u'4.3.0', u'4.2.0', u'4.1.0', u'4.0.0', u'2015.1.0rc2', u'2015.1.0', u'2015.1.0rc1', u'2015.1.0b3', u'2015.1.0b2', u'2015.1.0b1', u'2014.2.rc3', u'2014.2', u'2014.2.rc2', u'2014.2.rc1', u'2014.2.b3', u'2014.2.b2', u'2014.2.b1', u'2014.1.rc1', u'2014.1.b3', u'2014.1.b2', u'2014.1.b1']
determining earliest_version from branch
looking for ref 'master' as 'refs/heads/master'
found ref 'master' as 'refs/heads/master' at 180234b445f7127
looking for ref 'stable/mitaka' as 'refs/heads/
looking for ref 'stable/mitaka' as 'refs/remotes/
looking for ref 'stable/mitaka' as 'refs/tags/
looking for ref 'stable/mitaka' as 'refs/tags/
found ref 'stable/mitaka' as 'refs/tags/
looking for the branch before stable/mitaka
refs ['refs/tags/8.0.0', 'refs/tags/
s/2015.1.4', 'refs/tags/4.2.5', 'refs/tags/
tes/origin/
tags/2014.2.1', 'refs/remotes/
'refs/
Could not find branch 'stable/mitaka' among [u'stable/newton', u'stable/ocata', u'stable/pike']
earliest version to include is 5.1.0
looking for ref 'stable/mitaka' as 'refs/heads/
looking for ref 'stable/mitaka' as 'refs/remotes/
looking for ref 'stable/mitaka' as 'refs/tags/
looking for ref 'stable/mitaka' as 'refs/tags/
found ref 'stable/mitaka' as 'refs/tags/
ignoring null-merge commits
000001 fdd01ca736877aa
...
Using --earliest-version does work around this properly, FWIW.
summary: |
- Reno does not choose correct earliest version + Reno does not choose correct earliest version when old stable branches + are closed |
Changed in reno: | |
status: | New → In Progress |
assignee: | nobody → Doug Hellmann (doug-hellmann) |
importance: | Undecided → High |
Reviewed: https:/ /review. openstack. org/539009 /git.openstack. org/cgit/ openstack/ reno/commit/ ?id=b9cf9a7371e ec7f20089f51bbd 12e78963a10960
Committed: https:/
Submitter: Zuul
Branch: master
commit b9cf9a7371eec7f 20089f51bbd12e7 8963a10960
Author: Doug Hellmann <email address hidden>
Date: Mon Jan 29 14:38:18 2018 -0500
support scanning closed stable branches
The scanner was stopping too soon when reviewing the history of a
branch for which the previous branch had been "closed" by deleting the
branch and tagging it with an -eol tag. This fix treats closed -eol
branches the same way as open stable branches, using new configuration
options to allow projects that use different naming conventions to
have the same benefits.
Change-Id: I8024929a2a95e0 0df48ce56939d54 c1569fe18c5
Fixes-Bug: #1746076
Signed-off-by: Doug Hellmann <email address hidden>