non-unique unique ids cause errors

[Doug Hellmann]

when reno encounters files with the same UID it does not report the error, allowing those patches to be added to the repo. Then later when the release notes are built, the case causes a problem for reno and the build is broken.

http://logs.openstack.org/04/461004/5/check/gate-openstack-ansible-releasenotes/e9001b0/console.html#_2017-05-03_08_59_24_650953

Deleting the notes does not fix the problem: https://github.com/openstack/openstack-ansible/commit/121fb00c82b62be4585f16b95b4fcb67495d83f1

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/462220

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/462221

[Doug Hellmann (doug-hellmann)]

https://review.openstack.org/462199 is also related to this bug, but didn't have the bug ID in the first iteration so wasn't linked here automatically.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/462276

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/462199
Committed: https://git.openstack.org/cgit/openstack/reno/commit/?id=3f02991ce7c26aaed146cf28c28e63159ceb084e
Submitter: Jenkins
Branch: master

commit 3f02991ce7c26aaed146cf28c28e63159ceb084e
Author: Doug Hellmann <email address hidden>
Date: Wed May 3 11:59:03 2017 -0400

    deal with non-unique UIDs

    When we find multiple files added with the same UID in one patch, ignore
    them and emit a warning. That's bad input data, and we don't want to use
    them.

    Allow multiple files with the same UID to be deleted in a patch to
    support cleaning up existing situations where the add case was not
    caught properly.

    Related-Bug: #1688042
    Change-Id: I37fee0660ff541677d26770818764f7de2a2d863
    Signed-off-by: Doug Hellmann <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/462220
Committed: https://git.openstack.org/cgit/openstack/reno/commit/?id=dd5487e5d3665198ee9e5b5b2c3d5582db931dec
Submitter: Jenkins
Branch: master

commit dd5487e5d3665198ee9e5b5b2c3d5582db931dec
Author: Doug Hellmann <email address hidden>
Date: Wed May 3 12:39:50 2017 -0400

    modify the change aggregation api

    Move _aggregate_changes() to a class so we can track state.

    Related-Bug: #1688042
    Change-Id: I23a7add3a65c65e74b8e5b7378031346fe2a75b3
    Signed-off-by: Doug Hellmann <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/462221
Committed: https://git.openstack.org/cgit/openstack/reno/commit/?id=8b1a3c652747f2d70c2136642ad5e1875971a870
Submitter: Jenkins
Branch: master

commit 8b1a3c652747f2d70c2136642ad5e1875971a870
Author: Doug Hellmann <email address hidden>
Date: Wed May 3 12:54:27 2017 -0400

    do not allow multiple files with the same UID

    Prevent someone from adding multiple files with the same UID in the same
    commit. Ignore any existing commits with the problem as long as there
    was a later commit to delete the files.

    Closes-Bug: #1688042
    Change-Id: Id62361f3aba195417b369293e411c36172d27229
    Signed-off-by: Doug Hellmann <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/reno 2.2.1 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/462276
Committed: https://git.openstack.org/cgit/openstack/reno/commit/?id=06d6574d46091d48b9c78878cac04f639aec39cc
Submitter: Jenkins
Branch: master

commit 06d6574d46091d48b9c78878cac04f639aec39cc
Author: Doug Hellmann <email address hidden>
Date: Wed May 3 15:35:27 2017 -0400

    add a lint command

    Provide a tool for doing some basic input validation.

    Related-Bug: #1688042
    Change-Id: I850b57153c5286e19f4ac3af899b3d798aebd7d4
    Signed-off-by: Doug Hellmann <email address hidden>