warnings in stable/liberty release notes are breaking releasenotes job in master

[Matt Riedemann]

Seeing this here:

http://logs.openstack.org/69/268069/3/check/gate-nova-releasenotes/aaa7da2/console.html#_2016-01-15_11_27_02_287

fatal: Path 'releasenotes/notes/new-oslo-reports-option-619c3dbf3ae320fb.yaml' does not exist in '8b65185c14447d30dc323f1a43de8d9b253fae04'

That release note was deleted when we did this revert:

https://review.openstack.org/#/c/253821/

And it appears reno isn't handling it (or the sphinx extension).

[Matt Riedemann (mriedem)]

Nova is working around this for now by not treating warnings as errors:

https://review.openstack.org/#/c/268196/

[Matt Riedemann (mriedem)]

Doug thinks the problem is the warning here:

http://logs.openstack.org/69/268069/3/check/gate-nova-releasenotes/aaa7da2/console.html#_2016-01-15_11_27_03_131

2016-01-15 11:27:03.131 | Warning, treated as error:
2016-01-15 11:27:03.131 | /home/jenkins/workspace/gate-nova-releasenotes/releasenotes/source/liberty.rst:3: WARNING: Duplicate explicit target name: "announcement".

And that was introduced here:

https://review.openstack.org/#/c/267178/1/releasenotes/notes/12.0.1-cve-bugs-7b04b2e34a3e9a70.yaml

And not caught by the gate job b/c stable/liberty nova isn't treating warnings as errors:

https://github.com/openstack/nova/blob/stable/liberty/tox.ini#L213

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/268218

[Doug Hellmann (doug-hellmann)]

See https://review.openstack.org/268225 manage stderr output from external commands in reno.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/268243

[Doug Hellmann (doug-hellmann)]

Ongoing notes in this etherpad: https://etherpad.openstack.org/p/fix-nova-release-notes-build

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/268196
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ef8335185a517cb94bfa5d745298f810c304a507
Submitter: Jenkins
Branch: master

commit ef8335185a517cb94bfa5d745298f810c304a507
Author: Sylvain Bauza <email address hidden>
Date: Fri Jan 15 16:16:52 2016 +0100

    Workaround reno reverts by accepting warnings

    b2acc9fa864b6fe10bc0c5f3786b976b472b1b27 on stable/liberty introduced a
    sphinx warning which was not treated as an error in stable/liberty nova
    releasenotes tox runs so it slipped in, but it is treated as an error
    in master branch nova releasenotes tox runs, and since reno scans the
    branches, master is broken because of the error in stable/liberty.

    Plus, reno scans the git history, so right now it's not obvious how to
    travel back in time and fix the stable/liberty change.

    This change reduces the level of control we have by not treating reno warnings
    as errors. This is not fun but it's the only way we can still land
    release notes until an appropriate fix is merged (in reno or nova).

    Again, this is a temporary patch and we consider reverting it once bug 1534613
    is fixed.

    Change-Id: Iedb69c66632383e056840e3294a90cda651a8778
    Related-Bug: #1534613

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/268218
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=9c3cce75de6069edca35ce5046d4ce25a11b6337
Submitter: Jenkins
Branch: stable/liberty

commit 9c3cce75de6069edca35ce5046d4ce25a11b6337
Author: Matt Riedemann <email address hidden>
Date: Fri Jan 15 08:19:19 2016 -0800

    Fix warning in 12.0.1-cve-bugs-7b04b2e34a3e9a70.yaml release note

    The stable/liberty releasenotes tox target wasn't treating warnings
    as errors so this slipped in and it breaks the releasenotes job in
    master branch nova which does treat warnings as errors. So fix the
    issue in the release note first, which we have to merge because reno
    is reading from origin/stable/liberty. After we've merged the fix,
    then we can turn on -W to treat warnings as errors.

    Change-Id: Ibf84ee0a604da94f709a0eeb436efe988d21274c
    Closes-Bug: #1534613

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/268669

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/268669
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=702c01e26b8852cdcf1bf35cfc360ce5198b65ec
Submitter: Jenkins
Branch: master

commit 702c01e26b8852cdcf1bf35cfc360ce5198b65ec
Author: Matt Riedemann <email address hidden>
Date: Sat Jan 16 14:31:06 2016 +0000

    Revert "Workaround reno reverts by accepting warnings"

    This reverts commit ef8335185a517cb94bfa5d745298f810c304a507

    Now that Ibf84ee0a604da94f709a0eeb436efe988d21274c is merged
    on stable/liberty we should be OK again.

    Change-Id: I1a56426a86747bdcd1a9179ecbff46cf54a98202
    Related-Bug: #1534613

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/268243
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0dac205ba513a93348ab5e45f928aafaad81c593
Submitter: Jenkins
Branch: stable/liberty

commit 0dac205ba513a93348ab5e45f928aafaad81c593
Author: Matt Riedemann <email address hidden>
Date: Fri Jan 15 09:33:17 2016 -0800

    Treat sphinx warnings as errors when building release notes

    Once 12.0.1-cve-bugs-7b04b2e34a3e9a70.yaml is fixed and merged to
    origin/stable/liberty we can land this change to keep us from breaking
    release notes again.

    Change-Id: Ib68d9acf82813900ee434cb67f538d250cf7ee1e
    Closes-Bug: #1534613

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/268225
Committed: https://git.openstack.org/cgit/openstack/reno/commit/?id=052206e189f87fdc89c6c6562bea6c8033f1179a
Submitter: Jenkins
Branch: master

commit 052206e189f87fdc89c6c6562bea6c8033f1179a
Author: Doug Hellmann <email address hidden>
Date: Fri Jan 15 16:39:05 2016 +0000

    manage stderr output from external commands

    Only show error output from external commands in debug mode. This
    suppresses "fatal" messages that are fatal to git, but not reno, for
    example.

    Change-Id: Ic9a9fcf30fd2f9ff2c0a837de45dd062b7a900e8
    Related-Bug: 1534613

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/nova 12.0.1 release.