TAGS: Edit tags and remove their titles then create a new tag crashes the app
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Ubuntu Notes app |
High
|
Michael Zanetti | ||
Bug Description
STEPS:
1. Flash the phone with the latest RTM-proposed image
2. Install the reminders click package
3. reboot
4. open reminders
5. Select no to the account dialog
6. Create a note
7. save the note
8. Create and add a tag
9. From the drop down menu select tags
10. Tap on edit
11. Delete the text in the tag field
12. Create a new tag
EXPECTED:
A) I expect the text to reappear if I delete it's text and I don't replace it.
B) I don't expect the new tag to crash the app
ACTUAL:
The text is removed but the tags name remains this is confusing as it should now be named nothing. On the new tag being create the application freezes and eventually crashes and closes.
Related branches
- Riccardo Padovani: Approve on 2015-03-04
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration) on 2015-03-04
-
Diff: 1122 lines (+400/-146)17 files modifiedsrc/app/qml/components/NotebooksDelegate.qml (+46/-37)
src/app/qml/components/StatusBar.qml (+4/-2)
src/app/qml/components/TagsDelegate.qml (+21/-27)
src/app/qml/reminders.qml (+13/-1)
src/app/qml/ui/NotebooksPage.qml (+50/-1)
src/app/qml/ui/TagsPage.qml (+45/-10)
src/libqtevernote/jobs/savenotebookjob.cpp (+2/-0)
src/libqtevernote/notebook.cpp (+21/-0)
src/libqtevernote/notebook.h (+7/-0)
src/libqtevernote/notebooks.cpp (+11/-6)
src/libqtevernote/notebooks.h (+3/-3)
src/libqtevernote/notesstore.cpp (+164/-42)
src/libqtevernote/notesstore.h (+6/-8)
src/libqtevernote/tag.cpp (+6/-0)
src/libqtevernote/tag.h (+1/-0)
src/libqtevernote/tags.cpp (+0/-6)
src/libqtevernote/tags.h (+0/-3)
| Changed in reminders-app: | |
| assignee: | nobody → Michael Zanetti (mzanetti) |
| Michael Zanetti (mzanetti) wrote : | #1 |
| Changed in reminders-app: | |
| status: | New → In Progress |
| importance: | Undecided → High |
Fix committed into lp:reminders-app at revision 369, scheduled for release in reminders-app, milestone 2014-11-27
| Changed in reminders-app: | |
| status: | In Progress → Fix Committed |
| Changed in reminders-app: | |
| status: | Fix Committed → Fix Released |
Thanks Dave, I've fixed the renaming of tags to be more user friendly and more clearly disallow empty names. Unfortunately I can't really reproduce the crash. I had it crashing once after hammering the related ui with touch events, but that stack trace only went straight into the QML engine. Following your steps to reproduce didn't get it crashing for me.