Missing guard checks in _get_cpid_from_keystone allow cpid to be None

[Daryl Walleck]

In refstack-client, the _get_cpid_from_keystone method should always return the service id. However, the case where the identity endpoint is not found in the catalog is not handled (this is happening right now with Rackspace's public cloud). If the identity endpoint is not found, there is not a guard check in place (https://github.com/openstack/refstack-client/blob/master/refstack_client/refstack_client.py#L168, https://github.com/openstack/refstack-client/blob/master/refstack_client/refstack_client.py#L153) to handle this case, probably with an else clause to the for loops.
At the least we should provide a warning log entry that the cpid could not be retrieved. It might also make sense to exit with an error at this point as well.

[Catherine Diep (cdiep)]

Confirm that RefStack should handle the error case where catalog information returned does not include identity endpoint/service IDs.

[David Paterson (davpat2112)]

This change is broken unless the first service['type'] == 'identity'. If the first service type is 'volume' for instance, we raise exception and exit loop, never reaching the identity service. We should add unit tests.

Breaks here:
 for service in token['catalog']:
    if service['type'] == 'identity' and \
     'id' in service and service['id'] is not None:
         return service['id']
     else:
         message = "Unable to retrive CPID. " + \
             "Identity service ID was not " + \
             "found in Keystone v3 catalog."
         self.logger.error(message)
         raise RuntimeError(message)

[David Liu (lzbj)]

Thank you, I'll add another bug for it. https://bugs.launchpad.net/refstack/+bug/1515880

[Catherine Diep (cdiep)]

David, Thank you for your quick identification of the issue ... A fix was submitted with https://review.openstack.org/#/c/245007/ . .. We would really appreciate your review ... Thanks again!

[Catherine Diep (cdiep)]

This bug is fixed with https://review.openstack.org/#/c/245007/ merged on November 18, 2015