Strange behavior of metadata lookup button in Document Properties dialog

Bug #133074 reported by Alexey Balmashnov
4
Affects Status Importance Assigned to Milestone
Referencer
Fix Released
Undecided
Unassigned

Bug Description

The "Look up..." button is always turned on.

Although, if I understand it correctly, this button should be enabled, when url to look for a document metadata is already assigned (available), or such data is being entered in the dialog.

Revision history for this message
Alexey Balmashnov (a.balmashnov) wrote :

Referencer 1.0.4 and svn rev 542 are affected

Revision history for this message
John S (jcspray) wrote :

Patch is the right idea, but needs a couple of changes:
 - DOI isn't the only way to get metadata, there's also eprint, which is considered an "extra field". So sensitivity also needs updating on adding, removing or editing an extra field, and the update needs to check whether the eprint field is present.
 - In update(), canWebLink should be canGetMetadata

Cheers,
John

Revision history for this message
John S (jcspray) wrote :

Marking confirmed, on the basis that the "Look up..." button really shouldn't be sensitive when it's non-functional.

Changed in referencer:
status: New → Confirmed
Revision history for this message
Alexey Balmashnov (a.balmashnov) wrote :

Ok. It works now. Hope, I did not miss anything.

Revision history for this message
John S (jcspray) wrote :

I've (eventually!) committed this to subversion.

Changed in referencer:
status: Confirmed → Fix Committed
Changed in referencer:
milestone: none → 1.2.0
Changed in referencer:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.