Recipe Manager crashes when loading a recipe that has a description node that contains no description text

Bug #662459 reported by Stevie Griffiths
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Recipe Manager
In Progress
Critical
Unassigned

Bug Description

Recipe Manager crashes when loading a recipe that has a description node that contains no description.

--Original--
I added/removed a large amount of recipes from an existing test recipe and the file that saved cannot be loaded without crashing the application.

I will upload a copy of the recipe if you can tell me where the data directory is ;)

Revision history for this message
Stevie Griffiths (kastevie) wrote :

I don't believe a recipe description was saved in, so recipe-manager needs to handle the idea that a node "description" may be there without any assosciated value. I have a quick hack that allows the app to open for me, I will upload it.

Revision history for this message
Stevie Griffiths (kastevie) wrote :

branch here, I didn't make any effort to do it well because I have other things I should be doing but it fixes said problem ^_^.

https://code.launchpad.net/~kastevie/recipe-manager/recipe-crash

description: updated
summary: - Recipe Manager crashes when a recipe fails to load
+ Recipe Manager crashes when loading a recipe that has a description node
+ that contains no description text
Revision history for this message
Jeff Fortin Tam (kiddo) wrote :

Thanks for fixing a bug that was annoying me :) actually, I had already filed it as bug #652172.

At first glance, the patch looks good to me, what it does is basically replace missing descriptions by an empty string when displaying them in the GUI. I hadn't implemented this myself because I wasn't sure if it needed to be fixed in the file format or if it was indeed something you just parsed in the GUI.

Daniel, any thoughts?

Changed in recipe-manager:
status: New → In Progress
importance: Undecided → Critical
Revision history for this message
Jeff Fortin Tam (kiddo) wrote :

Merged to main, you can now set your branch status to Merged if you want.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.