Job Code popup doesn't display on download after preference change

Bug #1654781 reported by Monty Taylor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Rapid Photo Downloader
Status tracked in Pyqt
Pyqt
Fix Released
High
Damon Lynch

Bug Description

Running the latest alpha, when a folder hierarchy has a Job Code in it, the Job Code prompt is not displayed and the photos are downloaded into a place without the code. For instance:

<Image date (YYYY)>/<Job Code>

put photos into $PHOTO_ROOT/$YYYY instead of $PHOTO_ROOT/$YYYY

Digging in a little, I think it's because

        self.job_code = JobCode(self)

is done in init, and in JobCode

        self.need_job_code_for_naming = parent.prefs.any_pref_uses_job_code()

is done in the constructor. SO - if preferences are changed the RapidWindow object doens't make a new JobCode and then the boolean is always false.

If I stop rapid-photo-downloader and start it again after having made the preferences changes, it prompts for JobCode as expected.

Related branches

Damon Lynch (dlynch3)
Changed in rapid:
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Damon Lynch (dlynch3)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.