Show how many files have been marked

Bug #909406 reported by Bastian
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Rapid Photo Downloader
Status tracked in Pyqt
Pyqt
Fix Released
Low
Damon Lynch

Bug Description

Please show in the status bar how many files have been marked and maybe how many files are there in total. Or, perhaps, add the ability to change the initial default setting from select all to select none.

Related branches

Damon Lynch (dlynch3)
Changed in rapid:
status: New → Triaged
importance: Undecided → Wishlist
Jeff z (jz892)
description: updated
Revision history for this message
Jean-Pierre Verrue (jean-pierre-verrue) wrote :

I would also like to see how many files have been marked and how many files are there in total files. I would especially like to change the default setting from select all to select none.

Revision history for this message
Jean-Pierre Verrue (jean-pierre-verrue) wrote :

I wrote a patch that allows you to choose in preferences if files are automatically selected when loading or not.
Here it is :

----------------------------------------------------
$ diff prefsrapid.py ~/new/rapid
141a142
> "auto_select": prefs.Value(prefs.BOOL, True),
$ diff preferencesdialog.py ~/new/rapid
1440a1441,1442
> self.auto_select_checkbutton.set_active(
> self.prefs.auto_select)
1779a1782,1784
>
> def on_auto_select_checkbutton_toggled(self, checkbutton):
> self.prefs.auto_select = checkbutton.get_active()
$ diff rapid.py ~/new/rapid
670c670
< def add_file(self, rpd_file, generate_thumbnail):
---
> def add_file(self, rpd_file, generate_thumbnail, auto_select):
679c679
< True,
---
> auto_select,
4061c4061
< generate_thumbnail = not self.auto_start_is_on)
---
> generate_thumbnail = not self.auto_start_is_on, auto_select = self.prefs.auto_select)

--------------------------------------------

We must also change the prefs.ui file, but when you edit with glade, there are too many lines changed in order to make a significant diff. I can, of course, provide the file.

Does this patch can be integrated into the next version of rapid-photo-downloader ?

Thanks !

Revision history for this message
Damon Lynch (dlynch3) wrote :

Hi Jean-Pierre, thank you for your patch. Unfortunately it cannot be applied to the next release, because I'm currently porting the application to use PyQt, Python 3, libgphoto2 and 0mq: https://launchpad.net/rapid/pyqt

When this version is released it will have a new feature that remembers which files have previously been downloaded, by tracking them in an sqlite3 database: http://bazaar.launchpad.net/~dlynch3/rapid/zeromq_pyqt/revision/531

Although I have not yet done much work on implementing the GUI, my plan is that previously downloaded photos will not be marked. Perhaps with this feature, you feel less need for the feature you propose?

Revision history for this message
Jean-Pierre Verrue (jean-pierre-verrue) wrote :

Hi Damon, thank you for your quick response.
Indeed this new feature should meet my needs perfectly ! Do you need help with the development of this new release ? Does it will be available in the near future ?
In the meantime I will use my patch for my own needs, and maybe he can interest other user ? In particular bugs #909406 and #792230 writers. There he has a place to deposit the patched file for them ?

Sorry, the Google translation often produces a curious English. I try to do better, but ...

Damon Lynch (dlynch3)
Changed in rapid:
status: Triaged → Fix Committed
importance: Wishlist → Low
assignee: nobody → Damon Lynch (dlynch3)
Revision history for this message
Damon Lynch (dlynch3) wrote :

The next version will display a message like this in the status bar:

2 of 2 photos and videos (44.0MB). 212.4GB free on destination.

Ideally the message would be more terse, but I'm worried new users would be confused if the descriptive text is removed.

Jean-Pierre, I'll send you a message regarding the next release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.