install.py does not handle installer tar path with spaces

Bug #1787707 reported by Matthias Homann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Rapid Photo Downloader
Fix Released
Medium
Unassigned

Bug Description

Found a minor bug in the setup.py script if used with local installer tar file option.

If the tar file is in a different folder which has white spaces in the path, then the installation fails because the pip command can't find the file. The fix is simply to insert quotation marks around the installer file in the pip command.

Line 1627 in installer.py version 0.2.1, current code:
    cmd = make_pip_command(
        'install --user --disable-pip-version-check --no-deps {}'.format(installer)
    )

Improved code:
    cmd = make_pip_command(
        'install --user --disable-pip-version-check --no-deps "{}"'.format(installer)
    )

Related branches

Damon Lynch (dlynch3)
summary: - intall.py can't open installer tar file
+ install.py does not installer tar path with spaces
Damon Lynch (dlynch3)
summary: - install.py does not installer tar path with spaces
+ install.py does not handle installer tar path with spaces
Damon Lynch (dlynch3)
Changed in rapid:
importance: Undecided → Medium
status: New → Fix Committed
milestone: none → 0.9.11
Damon Lynch (dlynch3)
Changed in rapid:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.