Sandwich Menu - Settings do not work (problem with SIP 4.19.4 & PyQt 5.9)

Bug #1730062 reported by rainer
38
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Rapid Photo Downloader
Fix Released
High
Damon Lynch

Bug Description

If I click in the sandwich menu on Settings then I see only a dialog reporting an issue. The following information will be shown:

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/raphodo/rapid.py", line 2476, in doPreferencesAction
    dialog = PreferencesDialog(prefs=self.prefs, parent=self)
  File "/usr/lib/python3.6/site-packages/raphodo/preferencedialog.py", line 780, in __init__
    self.restoreButton.clicked.connect(self.restoreDefaultsClicked)
AttributeError: 'NoneType' object has no attribute 'clicked'

I did compile Rapid-Photo-Downloader 0.9.5b1.r1033 with Qt 5.10 beta on Arch Linux.

Related branches

Revision history for this message
rainer (r41n3r) wrote :

Maybe related to this issue, if I click in the Photos or Videos section on the right side on the settings symbol and then Custom, I get the following issue dialog:

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/raphodo/destinationdisplay.py", line 429, in doSubfolderCustom
    self.menuItemChosen(-1)
  File "/usr/lib/python3.6/site-packages/raphodo/destinationdisplay.py", line 448, in menuItemChosen
    self.sample_rpd_file)
  File "/usr/lib/python3.6/site-packages/raphodo/nameeditor.py", line 1011, in __init__
    self.helpButton.clicked.connect(self.helpButtonClicked)
AttributeError: 'NoneType' object has no attribute 'clicked'

Revision history for this message
Andreas Weigl (andreas-weigl) wrote :

I have the same issue. I get an error when I try to edit the preferences:

Traceback (most recent call last):
  File "/home/weigla/.local/lib/python3.6/site-packages/raphodo/rapid.py", line 2476, in doPreferencesAction
    dialog = PreferencesDialog(prefs=self.prefs, parent=self)
  File "/home/weigla/.local/lib/python3.6/site-packages/raphodo/preferencedialog.py", line 780, in __init__
    self.restoreButton.clicked.connect(self.restoreDefaultsClicked)
AttributeError: 'NoneType' object has no attribute 'clicked'

I also can't download pictures/videos. I am stuck in the "Apply Job Code to Download" dialogue. I am on 0.9.4. It used to work with this version. I tried to download some pictures and the downloader crashed. I reinstalled and now I get this.

Revision history for this message
Damon Lynch (dlynch3) wrote :

@rainer, running a snapshot PyQt with a beta version of Qt 5.10 is not something I'd recommend unless you want things to break! To run with a supported version of PyQt, from a terminal run this as your regular user (not root):

python3 -m pip install -U --user PyQt5

That will download and install PyQt and Qt 5.9 for your user only, not the system. You'll need to do that if you want to run Rapid Photo Downloader.

@Andreas, without a log file, it's pretty much impossible to diagnose your problem. However you should also first run the same command that I suggest to rainer.

Changed in rapid:
status: New → Invalid
Revision history for this message
Damon Lynch (dlynch3) wrote :

I forgot to add, if you still see the exception even after install PyQt5 as I suggest, then please open the bug again.

Revision history for this message
Alexey Brodkin (alexey-brodkin) wrote :

I'm seeing this issue as well and proposal with PyQt5 installed for user makes no sense for me,
see attached log.

I'm on 64-bit Fedora 24.

--------------------------->8-----------------------------
python3 -m pip install -U --user PyQt5
Requirement already up-to-date: PyQt5 in /home/abrodkin/.local/lib/python3.5/site-packages
Requirement already up-to-date: sip<4.20,>=4.19.3 in /home/abrodkin/.local/lib/python3.5/site-packages (from PyQt5)
--------------------------->8-----------------------------

Changed in rapid:
status: Invalid → Confirmed
Revision history for this message
Damon Lynch (dlynch3) wrote :

I suspect the problem has emerged with the very latest version of sip. I'll look into this some more. However, I still recommend not running a beta version of Qt in combo with PyQt!

Changed in rapid:
status: Confirmed → In Progress
importance: Undecided → High
assignee: nobody → Damon Lynch (dlynch3)
Revision history for this message
Alexey Brodkin (alexey-brodkin) wrote :

Well, given I'm on quite ancient Fedora version Qt5 version shouldn't be very recent not to say beta.

Revision history for this message
Damon Lynch (dlynch3) wrote :

Run this:

python3 -m pip uninstall sip
python3 -m pip install --user sip==4.19.3

The problem is solved. It looks like PyQt 5.9 and sip 4.19.4 do not work well together, at least with the current Rapid Photo Downloader code

Damon Lynch (dlynch3)
summary: - Sandwich Menu - Settings do not work
+ Sandwich Menu - Settings do not work (problem with SIP 4.19.4 & PyQt
+ 5.9)
Damon Lynch (dlynch3)
Changed in rapid:
milestone: none → 0.9.5
Damon Lynch (dlynch3)
Changed in rapid:
status: In Progress → Fix Released
Revision history for this message
Damon Lynch (dlynch3) wrote :

The PyQt developer confirmed the bug was regression in sip. He has released a new version 4.19.5.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.