Timeline shows wrong photo thumbnails when timeline interval set to 8 hours or more

Bug #1635913 reported by Gord
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Rapid Photo Downloader
Fix Released
High
Damon Lynch

Bug Description

RPD 0.9.0a4, Ubuntu 16.04LTS, connected device: SD card

When timeline slider is set to 4 hours or less, the thumbnails shown when an interval in the timeline is clicked are correct. When it is set to 8 hours or more, the thumbnails shown when an interval in the timeline is clicked are incorrect. With the slider set to 8 hours or more, the photos in the most recent session are not displayable at all.

I have attached screen shots. They don't show the tool tips that would illustrate the date/time of the photos, but you can see that different photos are shown for the same time interval with different slider settings.

Revision history for this message
Gord (gord-tomlin) wrote :
Revision history for this message
Gord (gord-tomlin) wrote :
Revision history for this message
Damon Lynch (dlynch3) wrote : Re: [Bug 1635913] Re: Timeline shows wrong photo thumbnails when timeline interval set to 8 hours or more

Please attach the complete log files. Otherwise the problem is impossible
to diagnose.

Revision history for this message
Gord (gord-tomlin) wrote :

Here ya go...thanks!

Revision history for this message
Damon Lynch (dlynch3) wrote :

Are you able to replicate the problem? I've not seen this behavior myself on any of the files I've tested it with.

Revision history for this message
Gord (gord-tomlin) wrote :

No, I could create it at will at that time, but have not seen it lately. When the problem occurred, I had a fairly large backlog of images to download, and they had quite a wide time range. I'll try putting a large number of photos with a wide date range onto an SD card and see if I can recreate it.

Revision history for this message
Gord (gord-tomlin) wrote :

I made several attempts to recreate this problem without success. I'm fine with it being closed. I will watch for it in the future and if I ever see it again I can collect fresh doc.

Revision history for this message
Damon Lynch (dlynch3) wrote :

My guess is that the fix released some release ago for a threading problem may have resolved this problem too. Marking it as fix released, for now.

Changed in rapid:
status: New → Incomplete
status: Incomplete → Fix Released
Revision history for this message
Damon Lynch (dlynch3) wrote :

I have made some changes in the Timeline code, that may affect the problem. Let me know if you see it again.

Perhaps relevant: keep in mind thumbnails are sorted by modification time. The timeline is sorted by creation time, which can be confusing if you're not aware of that.

Changed in rapid:
assignee: nobody → Damon Lynch (dlynch3)
importance: Undecided → High
Revision history for this message
Gord (gord-tomlin) wrote :

I haven't seen this problem in quite a while, but I'll continue to watch for it.

I wasn't aware of the different sort orders for the timeline and the thumbnails. I think most people would find that surprising. It might be worthwhile to make that very clear in the doc.

Having said that, I don't think it is applicable to the problem I saw. Making the timeline interval longer caused completely different photos to be displayed and the most recent photos to not be displayable at all.

Revision history for this message
Damon Lynch (dlynch3) wrote :

For important performance reasons, thumbnails are sorted by modification time, because the creation time is unknown until thumbnails are generated or if they are not generated, when the file is downloaded.

For the Timeline, it makes more sense to use the creation time.

All of this only matters, of course, when the modification time and creation time differ. People will only see this problem when they're renaming files already on their computer. Which as you know, is not something I prioritize.

Regarding the problem you've seen, when the next version is released, you can keep an eye out to see if the problem pops up again. I suspect it will not. I suspect the problem was caused by an exception being generated when you clicked on a row, which meant the display of the thumbnails was not being changed when it should have. That exception was caused by an error in the algorithm I wrote to generate the Timeline.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.