Rally does not support create verifier from gerrit source

Bug #1737529 reported by Bin Bin Cong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Rally
Fix Released
Low
Unassigned

Bug Description

I tried to use rally to create a tempest verifier whose source code is from gerrit, but it failed with below error:

rally verify create-verifier --name neutron-tempest --type tempest --source ssh://<email address hidden>:294/tempest --version testbranch
2017-12-11 08:44:35.637 42 INFO rally.api [-] Creating verifier 'tempest'.
Source path 'ssh://<email address hidden>:294/tempest' is not valid.

I checked the code and it seems that the URL reg can only accept a http or https link, but not a ssh link. I think ssh link should also be accepted since it is the common way to clone code from gerrit.

URL_RE = re.compile(
    r"^(?:http|ftp)s?://" # http:// or https://
    r"(?:(?:[A-Z0-9](?:[A-Z0-9-]{0,61}[A-Z0-9])?\.)+" # domain
    r"(?:[A-Z]{2,6}\.?|[A-Z0-9-]{2,}\.?)|" # domain
    r"localhost|" # localhost
    r"\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})" # IP
    r"(?::\d+)?" # optional port
    r"(?:/?|[/?]\S+)$", re.IGNORECASE)

Changed in rally:
status: New → In Progress
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to rally (master)

Reviewed: https://review.openstack.org/529005
Committed: https://git.openstack.org/cgit/openstack/rally/commit/?id=4dd502bb61859b1ded2544adff998e3c0495db47
Submitter: Zuul
Branch: master

commit 4dd502bb61859b1ded2544adff998e3c0495db47
Author: BinBin Cong <email address hidden>
Date: Tue Dec 12 14:08:03 2017 +0800

    Add support for ssh source

    For gerrit, it only support ssh source, with this patch,
    you can use gerrit link ssh source for verification adding.

    Change-Id: I9b0e98008f624113fcdf29b62e66f983407035e5
    Closes-Bug: #1737529

Changed in rally:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.