Rally does not support create verifier from gerrit source
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Rally |
Fix Released
|
Low
|
Unassigned |
Bug Description
I tried to use rally to create a tempest verifier whose source code is from gerrit, but it failed with below error:
rally verify create-verifier --name neutron-tempest --type tempest --source ssh://<email address hidden>:294/tempest --version testbranch
2017-12-11 08:44:35.637 42 INFO rally.api [-] Creating verifier 'tempest'.
Source path 'ssh://<email address hidden>
I checked the code and it seems that the URL reg can only accept a http or https link, but not a ssh link. I think ssh link should also be accepted since it is the common way to clone code from gerrit.
URL_RE = re.compile(
r"^
r"(
r"(
r"localhost|" # localhost
r"\
r"(?::\d+)?" # optional port
r"(
Changed in rally: | |
status: | New → In Progress |
importance: | Undecided → Low |
Reviewed: https:/ /review. openstack. org/529005 /git.openstack. org/cgit/ openstack/ rally/commit/ ?id=4dd502bb618 59b1ded2544adff 998e3c0495db47
Committed: https:/
Submitter: Zuul
Branch: master
commit 4dd502bb61859b1 ded2544adff998e 3c0495db47
Author: BinBin Cong <email address hidden>
Date: Tue Dec 12 14:08:03 2017 +0800
Add support for ssh source
For gerrit, it only support ssh source, with this patch,
you can use gerrit link ssh source for verification adding.
Change-Id: I9b0e98008f6241 13fcdf29b62e66f 983407035e5
Closes-Bug: #1737529