Existing users get's their role un-assigned with latest version

[Srinivas Sakhamuri]

Tried to specify the existing users using this template https://github.com/openstack/rally/blob/master/samples/deployments/existing-with-predefined-users.json

But rally ended up un-assigning the role to the user causing subsequent failures authenticated, which require a manual fix in the keystone databse. Repro steps are

Create an deployment file similar to above and specify the accounts you want to use with Rally testing.
Run any rally context that needs users, then rally proceeds to delete the role assigned to the account.

[Andriy Kurilin (andreykurilin)]

Can you share your task config file which resets the roles?

[Launchpad Janitor (janitor)]

[Expired for Rally because there has been no activity for 60 days.]

[Srinivas Sakhamuri (ssakhamuri)]

This happens when using existing users which already has admin role, when the task file contains a role context for e.g. Admin role context, rally attempts to assign the role and un-assigns at the end of the test, causing issues while using those accounts again for further testing.

[Srinivas Sakhamuri (ssakhamuri)]

https://review.openstack.org/531237

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/531237
Committed: https://git.openstack.org/cgit/openstack/rally/commit/?id=a1d40cd733360be15d6a38c66385cf475ea4feef
Submitter: Zuul
Branch: master

commit a1d40cd733360be15d6a38c66385cf475ea4feef
Author: Srinivas Sakhamuri <email address hidden>
Date: Thu Jan 4 15:18:02 2018 -0500

    Ensure cleanup is performed correctly on roles

    When using existing users (for e.g. LDAP setup) rally when specified
    roles context it tends to assign and remove roles, which can be problematic
    if the roles are already assigned to the users. This fix checks whether the
    user already a member of the role, if so it doesn't attempt to cleanup

    Closes-Bug: #1720270

    Change-Id: I8638eb0e59fdea2fdbbdf87728da70530fd22e14