CinderVolumes.create_volume_from_snapshot has wrong order deleting source snapshot before volume

[Yuming Ma]

Rally scenario CinderVolumes.create_volume_from_snapshot creates volume from snapshot, but it deletes the snapshot before the volume. The correct order should be deleting volume before the source snapshot, e.g. proposed change:

diff --git a/rally/plugins/openstack/scenarios/cinder/volumes.py b/rally/plugins/openstack/scenarios/cinder/volumes.py
index cf1ac53..db7bf74 100644
--- a/rally/plugins/openstack/scenarios/cinder/volumes.py
+++ b/rally/plugins/openstack/scenarios/cinder/volumes.py
@@ -794,8 +794,8 @@ class CreateVolumeFromSnapshot(cinder_utils.CinderBasic):
                                            **kwargs)

         if do_delete:
- self.cinder.delete_snapshot(snapshot)
             self.cinder.delete_volume(volume)
+ self.cinder.delete_snapshot(snapshot)

 @types.convert(image={"type": "glance_image"})

[Yuming Ma (yumima)]

https://review.openstack.org/#/c/505397/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/593693
Committed: https://git.openstack.org/cgit/openstack/rally-openstack/commit/?id=d380513ad379a7b6b4b91d8dd89de5b2ab2486ae
Submitter: Zuul
Branch: master

commit d380513ad379a7b6b4b91d8dd89de5b2ab2486ae
Author: Chuck Short <email address hidden>
Date: Mon Aug 20 12:34:53 2018 -0400

    Correct snapshot ordering

    Rally scenario CinderVolumes.create_volume_from_snapshot creates volume from snapshot,
    but it deletes the snapshot before the volume.
    The correct order should be deleting volume before the source snapshot,

    Closes bug #1718280

    Change-Id: I1bf7e21d92a501409552a2e83d229d082c31c9c5
    Signed-off-by: Chuck Short <email address hidden>